Re: [PATCH] powerpc/rtas_flash: New return code to indicate FW entitlement expiry

[Vasant Hegde <hegdevasant@linux.vnet.ibm.com>]

On 04/23/2013 06:10 AM, Benjamin Herrenschmidt wrote:
> On Fri, 2013-04-19 at 17:14 +0530, Vasant Hegde wrote:
>> Add new return code to rtas_flash to indicate firmware entitlement
>> expiry. This will be used by the update_flash script to return
>> appropriate message to the user.
>
> What's the point of that patch ? It adds a definition to a private .c
> file not exposed to user space and doesn't do anything with it ...
>

This is to keep our code in sync with PAPR. And when we get this return
code from "ibm,validate-flash-image" RTAS call, user space tools (update_flash) 
reads output buffer via /proc interface to display appropriate message to user.

-Vasant


> Ben.
>
>> Signed-off-by: Ananth N Mavinakayanahalli<ananth@in.ibm.com>
>> Signed-off-by: Vasant Hegde<hegdevasant@linux.vnet.ibm.com>
>> ---
>>   arch/powerpc/kernel/rtas_flash.c |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c
>> index a7020d2..0a12c16 100644
>> --- a/arch/powerpc/kernel/rtas_flash.c
>> +++ b/arch/powerpc/kernel/rtas_flash.c
>> @@ -64,6 +64,7 @@
>>   #define VALIDATE_TMP_COMMIT_DL 4     /* Validate Return Status */
>>   #define VALIDATE_TMP_COMMIT    5     /* Validate Return Status */
>>   #define VALIDATE_TMP_UPDATE_DL 6     /* Validate Return Status */
>> +#define VALIDATE_OUT_OF_WRNTY  7     /* Validate Return Status */
>>
>>   /* ibm,manage-flash-image operation tokens */
>>   #define RTAS_REJECT_TMP_IMG   0
>
>