From mboxrd@z Thu Jan  1 00:00:00 1970
From: Markowski Bartosz <bartosz.markowski@tieto.com>
Date: Tue, 23 Apr 2013 09:30:44 +0200
Subject: [ath9k-devel] [PATCH 1/3] ath10k: kill A_PCIE_LOCAL_REG_READ
In-Reply-To: <87d2tlg0wi.fsf@kamboji.qca.qualcomm.com>
References: <1366637004-9424-1-git-send-email-bartosz.markowski@tieto.com>
	<1366637004-9424-2-git-send-email-bartosz.markowski@tieto.com>
	<87d2tlg0wi.fsf@kamboji.qca.qualcomm.com>
Message-ID: <517638A4.3090701@tieto.com>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

On 23/04/13 09:29, Kalle Valo wrote:
> Bartosz Markowski <bartosz.markowski@tieto.com> writes:
>
>> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
> [...]
>
>> -#define A_PCIE_LOCAL_REG_READ(mem, addr) \
>> -	ioread32((mem) + PCIE_LOCAL_BASE_ADDRESS_T(ar) + (u32)(addr))
> I think it would be better to convert this to a function and call it
> ath10k_pci_reg_read32() or something like that. And the same for the
> write function.
>
ok