From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Scott <dave.scott@eu.citrix.com>
Subject: Re: [PATCH] Only call stat() when adding a disk if we
 expect a device to exist.
Date: Tue, 23 Apr 2013 10:52:06 +0100
Message-ID: <517659C6.40409@eu.citrix.com>
References: <1366709813-27967-1-git-send-email-dave.scott@eu.citrix.com>
	<1366710288.20256.87.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1366710288.20256.87.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 23/04/13 10:44, Ian Campbell wrote:
> On Tue, 2013-04-23 at 10:36 +0100, David Scott wrote:
>> >We consider calling stat() a helpful error check in the following
>> >circumstances only:
>> >  1. the disk backend type must be PHYsical
>> >  2. the disk backend domain must be the same as the running libxl
>> >     code (assumed to be 0)
> AKA LIBXL_TOOLSTACK_DOMID. That line could also do with wrapping but I
> can do that as I commit if you like.

Ah, I grepped around for stuff like "DOMID_SELF" but missed that one :-)

I'll resend...

Cheers,
Dave