Re: [PATCH] kernel 3.8: routerstationpro: use KERNEL_IMAGE_MAXSIZE to test the image

[Michel Thebeau <michel.thebeau@windriver.com>]

On 13-04-23 04:16 AM, Andrea Adami wrote:
> On Mon, Apr 22, 2013 at 11:20 PM,  <michel.thebeau@windriver.com> wrote:
>> From: Michel Thebeau <michel.thebeau@windriver.com>
>>
>> routerstationpro is limited to 16mb flash size.  Exceeding that size may
>> not be noticed immediately, which we don't want.
>>
>> "The current latest kernel for the routerstationpro machine is far
>> beyond the 16MB of it's flash size [0]. I think it would be good to
>> [test if the size of the image is above that size]."
>>
>> Setting this variable will enable the do_sizecheck task and produce an
>> error when the image is too large:
>>
>> "ERROR: This kernel (size=90230265 > 16777216) is too big for your
>> device. Please reduce the size of the kernel by making more of it
>> modular."
>>
>> Taken from commit 83716e40edacfd20dec8ef41f415ad5828d4643b.
>>
>> [YOCTO #3514]
>>
>> Signed-off-by: Michel Thebeau <michel.thebeau@windriver.com>
>> ---
>>  .../recipes-kernel/linux/linux-yocto_3.8.bbappend  |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/meta-yocto-bsp/recipes-kernel/linux/linux-yocto_3.8.bbappend b/meta-yocto-bsp/recipes-kernel/linux/linux-yocto_3.8.bbappend
>> index 479a386..769dcc0 100644
>> --- a/meta-yocto-bsp/recipes-kernel/linux/linux-yocto_3.8.bbappend
>> +++ b/meta-yocto-bsp/recipes-kernel/linux/linux-yocto_3.8.bbappend
>> @@ -12,3 +12,6 @@ COMPATIBLE_MACHINE_mpc8315e-rdb = "mpc8315e-rdb"
>>  COMPATIBLE_MACHINE_routerstationpro = "routerstationpro"
>>  COMPATIBLE_MACHINE_beagleboard = "beagleboard"
>>  COMPATIBLE_MACHINE_atom-pc = "atom-pc"
>> +
>> +# routerstationpro has a flash size of 16mb
>> +KERNEL_IMAGE_MAXSIZE_append_routerstationpro = "16777216"
> 
> Why would it need an _append_ ?
> KERNEL_IMAGE_MAXSIZE_routerstationpro = "16777216" should be enough.
> 
> And by the way such kernel sizes look really exaggerated.

Thanks Andrea,

I'll drop _append_.

I'm not sure what you mean mean by exaggerated.  I multiplied 16mb with
2^20 == 16777216.

M

> 
> Regards
> 
> Andrea
> 
> 
>> --
>> 1.7.9.7
>>
>> _______________________________________________
>> poky mailing list
>> poky@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/poky
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>