From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH 1/2] Thermal: exynos: Add clk_{un}prepare APIs Date: Tue, 23 Apr 2013 08:44:03 -0400 Message-ID: <51768213.5040602@ti.com> References: <1366285079-10395-1-git-send-email-sachin.kamat@linaro.org> <5175807C.4090005@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:38704 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755920Ab3DWMoS (ORCPT ); Tue, 23 Apr 2013 08:44:18 -0400 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Sachin Kamat Cc: Eduardo Valentin , linux-pm@vger.kernel.org, rui.zhang@intel.com, kgene.kim@samsung.com, patches@linaro.org, Amit Daniel Kachhap Rui, On 22-04-2013 23:38, Sachin Kamat wrote: > On 22 April 2013 23:55, Eduardo Valentin wrote: >> On 18-04-2013 07:37, Sachin Kamat wrote: >>> >>> clk_{un}prepare APIs are required to migrate to common >>> clock framework. While at it convert to use devm_clk_get as >>> it removes some cleanup code. >>> >>> Signed-off-by: Sachin Kamat >>> Cc: Amit Daniel Kachhap >>> --- >>> drivers/thermal/exynos_thermal.c | 10 +++++++--- >>> 1 file changed, 7 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/thermal/exynos_thermal.c >>> b/drivers/thermal/exynos_thermal.c >>> index e34d842..9df96e5 100644 >>> --- a/drivers/thermal/exynos_thermal.c >>> +++ b/drivers/thermal/exynos_thermal.c >>> @@ -937,12 +937,16 @@ static int exynos_tmu_probe(struct platform_device >>> *pdev) >>> return ret; >>> } >>> >>> - data->clk = clk_get(NULL, "tmu_apbif"); >>> + data->clk = devm_clk_get(&pdev->dev, "tmu_apbif"); >> >> >> Here you are also changing the sequence from clk_get(NULL, ...) to >> clk_get(&pdev->dev, ...). Is your platform code ready to match to your >> device node? > > Yes. This has been tested on Exynos4 and 5 DT enabled boards (Origen > 4210, 4412 and Arndale). In this case, this patch looks fine to me. Acked-by: Eduardo Valentin >