All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rich Johnston <rjohnston@sgi.com>
To: Zhao Hongjiang <zhaohongjiang@huawei.com>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfstests: capture the failure result of 310
Date: Tue, 23 Apr 2013 08:33:02 -0500	[thread overview]
Message-ID: <51768D8E.2060207@sgi.com> (raw)
In-Reply-To: <5175FC5C.5020607@huawei.com>

Thanks for making the suggested changes.

FYI it helps the review process if you include a version log below the 
header something like.

   Capture the failure by the way of counting dmesg errors and describe
   how the test triggers problems.

   Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>
   [eguan@redhat.com fix common file path and other cleanups]

   ---
   V1:
	Initial version

   V2:
	Added suggestions from xxx@somewhere.org to fix something
	Reworked logic for function blah

Minor description change, other than that, it looks good.

--Rich

Reviewed-by: Rich Johnston <rjohnston@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-04-23 13:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23  3:13 [PATCH v2] xfstests: capture the failure result of 310 Zhao Hongjiang
2013-04-23  3:13 ` Zhao Hongjiang
2013-04-23 13:33 ` Rich Johnston [this message]
2013-04-23 13:55 ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51768D8E.2060207@sgi.com \
    --to=rjohnston@sgi.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    --cc=zhaohongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.