All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
	linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [BUG] increased us/sys-load due to tty-layer in 2.6.38+ ?!
Date: Tue, 23 Apr 2013 15:38:43 +0200	[thread overview]
Message-ID: <51768EE3.6080005@pengutronix.de> (raw)
In-Reply-To: <517595B7.1030000@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1706 bytes --]

On 04/22/2013 09:55 PM, Marc Kleine-Budde wrote:
[...]

>>> This resulted in
>>>         f23eb2b2b28547fc70df82dd5049eb39bec5ba12
>>>         tty: stop using "delayed_work" in the tty layer
>>>
>>> as possible cause. Reverting this commit by hand in v3.8 showed a load distribution
>>> similar to 2.6.38.
>>> What I haven't done, is measure if the load is really increasing or if top only
>>> tells me so. Maybe the algorithm to calculate this somehow produces different
>>> results because of the switch from schedule_delayed_work to schedule_work?
>>> So, is this a bug, a feature, a symptom,...?
>>
>> It's a "fake" load (i.e. no extra cpu is being used, just a "busy" wait
>> is happening.)

The below test shows that with that offending patch, there is less time
to calculate PI. My conclusion from this is that he patch increases the
load generated by the processing of the serial line in the tty layer
and/or increased overhead by more context switches/scheduling.

> Another test was to measure how long it takes to calculate 10 k digits
> of PI. Less time means less load on the system by the tty layer:
> 
>                 idle         tty open     serial load
> 
> v2.6.38-good    20.9s        22.3s        32.8s
> v2.6.38-bad     20.9s        22.3s        51.5s

Are there any options to decrease the load to the old value and keep the
better latency introduce by that patch?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

      reply	other threads:[~2013-04-23 13:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08  9:25 [BUG] increased us/sys-load due to tty-layer in 2.6.38+ ?! Steffen Trumtrar
2013-04-08 15:06 ` Greg Kroah-Hartman
2013-04-09  7:30   ` Steffen Trumtrar
2013-04-22 15:56   ` Marc Kleine-Budde
2013-04-22 19:55   ` Marc Kleine-Budde
2013-04-23 13:38     ` Marc Kleine-Budde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51768EE3.6080005@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.trumtrar@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.