From: John Blackwood <john.blackwood@ccur.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] cpufreq_conservative: initialize the cpu_dbs_info_s cpu field
Date: Tue, 23 Apr 2013 10:27:22 -0500 [thread overview]
Message-ID: <5176A85A.7090609@ccur.com> (raw)
In-Reply-To: <CAOh2x=nZir=RohrbVJa1iWR47nmLKfG3it1UnWdt49oAKrBhWw@mail.gmail.com>
On 04/23/2013 10:19 AM, Viresh Kumar wrote:
> On Tue, Apr 23, 2013 at 8:11 PM, John Blackwood <john.blackwood@ccur.com> wrote:
>> In the cpufreq conservative module, the cpu field in the cpu_dbs_info_s
>> structure was not being initialized, and thus all cpus were scheduling
>> their do_dbs_timer() delayed work processing on cpu 0.
>>
>> Signed-off-by: John Blackwood <john.blackwood@ccur.com>
>> Index: b/drivers/cpufreq/cpufreq_conservative.c
>> ===================================================================
>> --- a/drivers/cpufreq/cpufreq_conservative.c
>> +++ b/drivers/cpufreq/cpufreq_conservative.c
>> @@ -506,6 +506,7 @@ static int cpufreq_governor_dbs(struct c
>> }
>> this_dbs_info->down_skip = 0;
>> this_dbs_info->requested_freq = policy->cur;
>> + this_dbs_info->cpu = cpu;
>>
>> mutex_init(&this_dbs_info->timer_mutex);
>> dbs_enable++;
>
> What have you rebased this on? I don't think its the latest code and is probably
> a bit old.
>
Hi Viresh,
Yes, you are right.
This has been fixed in a different way in the newer kernel source.
My apologies.
prev parent reply other threads:[~2013-04-23 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 14:41 [PATCH] cpufreq_conservative: initialize the cpu_dbs_info_s cpu field John Blackwood
2013-04-23 15:19 ` Viresh Kumar
2013-04-23 15:27 ` John Blackwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5176A85A.7090609@ccur.com \
--to=john.blackwood@ccur.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.