From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1UUgUZ-0003Ck-VL
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 12:54:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1UUgUV-00038R-8n
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 12:54:55 -0400
Received: from thoth.sbs.de ([192.35.17.2]:24000)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1UUgUU-00038E-VW
	for qemu-devel@nongnu.org; Tue, 23 Apr 2013 12:54:51 -0400
Message-ID: <5176BCD7.3060600@siemens.com>
Date: Tue, 23 Apr 2013 18:54:47 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1343401379-19495-1-git-send-email-pbonzini@redhat.com>
	<1343401379-19495-4-git-send-email-pbonzini@redhat.com>
	<51764A9C.8000508@siemens.com> <5176B339.5070108@redhat.com>
	<5176BA24.8020109@redhat.com>
In-Reply-To: <5176BA24.8020109@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2013-04-23 18:43, Paolo Bonzini wrote:
> Il 23/04/2013 18:13, Paolo Bonzini ha scritto:
>> Il 23/04/2013 10:47, Jan Kiszka ha scritto:
>>>>>          if (val & LSI_ISTAT0_SRST) {
>>>>> -            lsi_soft_reset(s);
>>>>> +            qdev_reset_all(&s->dev.qdev);
>>> What should ensure that all device resets are performed before the host
>>> reset? I'm asking as we just ran into the assert(!s->current) over
>>> 1.3.1. Or is there some patch from a later version missing (not seeing
>>> anything suspicious for lsi at least)?
>>
>> qdev should, but it looks like it uses pre-order instead of post-order.
> 
> Something like this series (based on 1.3.0), totally untested.

Forwarded to the folks who managed to trigger this. Will let you know.

Many thanks!
Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux