From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUhru-00020b-5s for qemu-devel@nongnu.org; Tue, 23 Apr 2013 14:23:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUhrt-0002Un-1h for qemu-devel@nongnu.org; Tue, 23 Apr 2013 14:23:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUhrs-0002UX-Ph for qemu-devel@nongnu.org; Tue, 23 Apr 2013 14:23:04 -0400 Message-ID: <5176D17B.7000000@redhat.com> Date: Tue, 23 Apr 2013 20:22:51 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366656797-3567-1-git-send-email-pbonzini@redhat.com> <1366656797-3567-3-git-send-email-pbonzini@redhat.com> <5176C78F.4080206@weilnetz.de> In-Reply-To: <5176C78F.4080206@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] win32: add readv/writev emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , Blue Swirl , qemu-devel > Hi Paolo, > > your patch looks good, but maybe you could modify the signatures > of readv, writev to match the Linux originals (missing const, use int): > > ssize_t readv(int fd, const struct iovec *iov, int iovcnt); > ssize_t writev(int fd, const struct iovec *iov, int iovcnt); > > In an updated patch the tab characters could be replaced by a space > to make checkpatch.pl happy. Ok, I'll send it tomorrow. I'll make a pull request myself to streamline the process in time for -rc0. Paolo