From: Bo Shen <bard.shen@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] Remove ^L string
Date: Wed, 24 Apr 2013 09:43:08 +0800 [thread overview]
Message-ID: <517738AC.7080700@gmail.com> (raw)
In-Reply-To: <20130423204102.1C08F384879@gemini.denx.de>
Hi Wolfgang,
On 4/24/2013 4:41, Wolfgang Denk wrote:
> Dear Tom,
>
> In message <20130423185329.GK14952@bill-the-cat> you wrote:
>>
>>>> Remove ^L string
>>>
>>> What is the purpose of this modification?
>>
>> Cleaning up the sources? These are not intentionally inserted
>> characters we have in a handful of files. Mainly in "bedbug" files and
>> malloc related files.
> I have to admit that I did not find the proginal source reference any
> more, but my understanding is that this was imported code from another
> project, and I see little reason to "fix" it (i. e. making it
> incompatible to the original code) if there is not a good reason for
> it.
>
> Formfeed characters in the source code are IMHO mostly a matter of
> taste - in the editor they don't really hurt, and who of you has been
> printing the U-Boot source code in the last decade?
To be honest, I have not test it, I just see the ^L string in source
file with editor. And try to clean it.
> So my recommendation is to just ignore this. Let's focus on real
> problems, or at least real coding style violations.
OK. We can ignore this, and let's focus on real problems.
Best Regards,
Bo Shen
> Best regards,
>
> Wolfgang Denk
>
prev parent reply other threads:[~2013-04-24 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 16:11 [U-Boot] [RFC] Remove ^L string Bo Shen
2013-04-23 18:09 ` Wolfgang Denk
2013-04-23 18:53 ` Tom Rini
2013-04-23 20:41 ` Wolfgang Denk
2013-04-24 1:43 ` Bo Shen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517738AC.7080700@gmail.com \
--to=bard.shen@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.