All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: What's cooking in git.git (Apr 2013, #08; Tue, 23)
Date: Wed, 24 Apr 2013 09:57:06 +0200	[thread overview]
Message-ID: <51779052.8020507@viscovery.net> (raw)
In-Reply-To: <7vwqrtgi1r.fsf@alter.siamese.dyndns.org>

Am 4/23/2013 21:31, schrieb Junio C Hamano:
> * fc/transport-helper-error-reporting (2013-04-17) 9 commits
>   (merged to 'next' on 2013-04-22 at 5ba6467)
>  + transport-helper: update remote helper namespace
>  + transport-helper: trivial code shuffle
>  + transport-helper: warn when refspec is not used
>  + transport-helper: clarify pushing without refspecs
>  + transport-helper: update refspec documentation
>  + transport-helper: clarify *:* refspec
>  + transport-helper: improve push messages
>  + transport-helper: mention helper name when it dies
>  + transport-helper: report errors properly
> 
>  Update transport helper to report errors and maintain ref hierarchy
>  used to keep track of remote helper state better.
> 
>  Will merge to 'master'.

Please don't, yet. There is a new test case that fails on Windows. I'll
have to figure out a work-around.

In git-remote-testgit we have this code:

	before=$(git for-each-ref --format='%(refname) %(objectname)')

	git fast-import "${testgitmarks_args[@]}" --quiet

	after=$(git for-each-ref --format='%(refname) %(objectname)')

	# figure out which refs were updated
	join -e 0 -o '0 1.2 2.2' -a 2 <(echo "$before") <(echo "$after") |
	while read ref a b
	do
		test $a == $b && continue
		echo "ok $ref"
	done

The failure is in the 'join' line: Bash on Windows does not implement
process substitution, and we do not have 'join'. This failing code exists
since 93b5cf9c (remote-testgit: report success after an import,
2012-11-28), but apparently, it did not matter so far.

-- Hannes

  reply	other threads:[~2013-04-24  7:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 20:07 What's cooking in git.git (Apr 2013, #07; Mon, 22) Junio C Hamano
2013-04-23 19:31 ` What's cooking in git.git (Apr 2013, #08; Tue, 23) Junio C Hamano
2013-04-24  7:57   ` Johannes Sixt [this message]
2013-04-24  8:04     ` Felipe Contreras
2013-04-24  8:30       ` Johannes Sixt
2013-04-25  5:56         ` [PATCH] git-remote-testgit: avoid process substitution Johannes Sixt
2013-04-25 14:57           ` Junio C Hamano
2013-04-25 17:50             ` Felipe Contreras
2013-04-25 18:25               ` Junio C Hamano
2013-04-25 19:24                 ` Felipe Contreras
2013-04-25 20:06                   ` Junio C Hamano
2013-04-25 20:31                     ` Felipe Contreras
2013-04-26 21:56           ` Felipe Contreras
2013-04-26 22:25             ` Junio C Hamano
2013-04-26 22:45               ` Felipe Contreras
2013-04-26 23:26                 ` Re* " Junio C Hamano
2013-04-27 19:13                   ` Johannes Sixt
2013-04-29 17:36                     ` Junio C Hamano
2013-04-29 17:41                       ` [PATCH 0/3] De-bashing remote-testgit Junio C Hamano
2013-04-29 17:41                         ` [PATCH 1/3] git-remote-testgit: avoid process substitution Junio C Hamano
2013-04-29 17:41                         ` [PATCH 2/3] git-remote-testgit: further remove some bashisms Junio C Hamano
2013-04-29 17:41                         ` [PATCH 3/3] git-remote-testgit: build it to run under $SHELL_PATH Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51779052.8020507@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.