From: Mark Jackson <mpfj-list@newflow.co.uk>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fs/ubifs: factorize all the "depends on" into "if...endif" blocks
Date: Wed, 24 Apr 2013 13:30:25 +0100 [thread overview]
Message-ID: <5177D061.6020905@newflow.co.uk> (raw)
All the UBIFS options use "depends on BR2_TARGET_ROOTFS_UBIFS" but
we can simplify the config file by enclosing them in an "if..endif"
block.
We also do the same for the "depends on BR2_TARGET_ROOTFS_UBI".
Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
---
fs/ubifs/Config.in | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/fs/ubifs/Config.in b/fs/ubifs/Config.in
index f17c7dc..c1d2ce7 100644
--- a/fs/ubifs/Config.in
+++ b/fs/ubifs/Config.in
@@ -3,21 +3,20 @@ config BR2_TARGET_ROOTFS_UBIFS
help
Build a ubifs root filesystem
+if BR2_TARGET_ROOTFS_UBIFS
+
config BR2_TARGET_ROOTFS_UBIFS_LEBSIZE
hex "UBI logical erase block size"
- depends on BR2_TARGET_ROOTFS_UBIFS
default 0x1f800
config BR2_TARGET_ROOTFS_UBIFS_MINIOSIZE
hex "UBI minimum I/O size"
- depends on BR2_TARGET_ROOTFS_UBIFS
default 0x800
help
Some comment required here
config BR2_TARGET_ROOTFS_UBIFS_MAXLEBCNT
int "Maximum LEB count"
- depends on BR2_TARGET_ROOTFS_UBIFS
default 2048
help
Some comment required here
@@ -25,7 +24,6 @@ config BR2_TARGET_ROOTFS_UBIFS_MAXLEBCNT
choice
prompt "ubifs runtime compression"
default BR2_TARGET_ROOTFS_UBIFS_RT_LZO
- depends on BR2_TARGET_ROOTFS_UBIFS
help
Select which compression format to use at run-time within
the ubifs file system.
@@ -50,7 +48,6 @@ endchoice
choice
prompt "Compression method"
default BR2_TARGET_ROOTFS_UBIFS_NONE
- depends on BR2_TARGET_ROOTFS_UBIFS
help
Select which compression format to compress the final image
into.
@@ -79,19 +76,18 @@ endchoice
config BR2_TARGET_ROOTFS_UBIFS_OPTS
string "Additional mkfs.ubifs options"
- depends on BR2_TARGET_ROOTFS_UBIFS
help
Any additional mkfs.ubifs options you may want to include.
config BR2_TARGET_ROOTFS_UBI
- depends on BR2_TARGET_ROOTFS_UBIFS
bool "Embed into an UBI image"
help
Build an ubi image from the ubifs one (with ubinize).
+if BR2_TARGET_ROOTFS_UBI
+
config BR2_TARGET_ROOTFS_UBI_PEBSIZE
hex "UBI physical erase block size"
- depends on BR2_TARGET_ROOTFS_UBI
default 0x20000
help
Tells ubinize the physical eraseblock size of the flash chip
@@ -99,7 +95,6 @@ config BR2_TARGET_ROOTFS_UBI_PEBSIZE
config BR2_TARGET_ROOTFS_UBI_SUBSIZE
int "UBI sub-page size"
- depends on BR2_TARGET_ROOTFS_UBI
default 512
help
Tells ubinize that the flash supports sub-pages and the sub-page
@@ -107,6 +102,9 @@ config BR2_TARGET_ROOTFS_UBI_SUBSIZE
config BR2_TARGET_ROOTFS_UBI_OPTS
string "Additional ubinize options"
- depends on BR2_TARGET_ROOTFS_UBI
help
Any additional ubinize options you may want to include.
+
+endif
+
+endif
--
1.7.9.5
next reply other threads:[~2013-04-24 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 12:30 Mark Jackson [this message]
2013-04-24 21:26 ` [Buildroot] [PATCH] fs/ubifs: factorize all the "depends on" into "if...endif" blocks Yann E. MORIN
2013-04-25 2:23 ` Thomas Petazzoni
2013-04-25 7:49 ` Mark Jackson
2013-04-25 8:06 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5177D061.6020905@newflow.co.uk \
--to=mpfj-list@newflow.co.uk \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.