From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <chegger@amazon.de>
Subject: Re: [PATCH] docs: make 'gmake dist-docs' work
Date: Wed, 24 Apr 2013 14:54:07 +0200
Message-ID: <5177D5EF.5040908@amazon.de>
References: <51752547.70801@amazon.de>
	<1366804085.20256.290.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1366804085.20256.290.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 24.04.13 13:48, Ian Campbell wrote:
> On Mon, 2013-04-22 at 12:55 +0100, Egger Christoph wrote:
>> doc: Makefile fixes
>>     
>> - use correct pathes (make gmake dist-docs from toplevel directory work)
>> - use tools as found by configure (perl)
> 
> Did you test this?

Yes.

[...]

> $(PERL) is defined in config/Tools.mk but docs/Makefile by design only
> includes config/Docs.mk. I think you need to check for perl in
> docs/configure.ac as well and propagate the result into config/Docs.mk
>         AC_ARG_VAR([PERL], [Path to Perl parser])
>         AX_PATH_PROG_OR_FAIL([PERL], [perl])

docs/Makefile also includes Config.mk which in turn includes
config/Tools.mk.
>>From there $(PERL) is defined and makes this patch work.

Christoph

> The reason for checking twice is to support people who only want to
> build the docs and not the tools and therefore only run configure in the
> subdirectory.
> 
> Ian.
> 
>