From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV0Cl-0007uQ-K7 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 09:57:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV0Cg-0006FG-M6 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 09:57:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV0Cg-0006E7-Cm for qemu-devel@nongnu.org; Wed, 24 Apr 2013 09:57:46 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3ODvjrO031332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 24 Apr 2013 09:57:45 -0400 Message-ID: <5177E4D8.7010702@redhat.com> Date: Wed, 24 Apr 2013 07:57:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366810169-23700-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1366810169-23700-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2XSMINDHDKEVNTEEPOMQM" Subject: Re: [Qemu-devel] [PATCH] block: Disable driver-specific options for 1.5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2XSMINDHDKEVNTEEPOMQM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/24/2013 07:29 AM, Kevin Wolf wrote: > We don't want to commit to the API yet before everything is worked out.= > Disable it for the 1.5 release. This commit is meant to be reverted > after the 1.5 release. Agreed that command line support without QMP support is awkward, so crippling the code until we have full support in 1.6 is perfectly fine for libvirt's perspective. >=20 > The disabling of the driver-specific options is achieved by applying th= e > old checks while parsing the command line. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 118 +++++++++++++++++++++++++++++++++++++++= ++++++-- > tests/qemu-iotests/group | 2 +- > 2 files changed, 115 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2XSMINDHDKEVNTEEPOMQM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRd+TYAAoJEKeha0olJ0NqrskH/0VOWV4Yfvb7pcyXRKJ+VH82 NGphnS7ZSJOJaEdFIAFCLwWQQ8lI0rVQ+PJZh8dj0MygJI5kJ8DLsBoaT26oqjiO g+Glkb0yL75l2aCbk6L4SShgSYDO9cDjvfCmIvwO6zcqoXxOhJTKZfxSiNE7f+im bj5KM9msIELSkni2+S/Mx4HyqNbH98AogevU0Uo3UuRbydNiCWWc9u4ra9PaV2PM AI9AVbXcrz1oHbT6fbydTt9ccqxiX+OcIzM24uo5R2Rc4BJ3ql9gOa36KeoTiNOE QBmXp+lZRNH2uiUZAio42Pt6jT3/1rG8foa0khBSEEfqZAFZPkX8yI6E2ztwcjM= =zmL4 -----END PGP SIGNATURE----- ------enig2XSMINDHDKEVNTEEPOMQM--