Re: [Qemu-devel] [PATCH v2 00/12] covert savevm, loadvm and delvm into qapi

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1987 bytes --]

On 04/24/2013 09:31 AM, Pavel Hrdina wrote:
> I'm sending patches for all commands in one patch series because the
> savevm command depends on delvm command.

I debated whether to call this out, but here goes:

I pointed out s/covert/convert/ on the subject line of v1; that can't
bode too well if the v2 still has the same problem, even if the problem
does not affect anything that gets committed into git.

Here's hoping the rest of the series is better...

> 
> This patch series introduces new design of these commands:

At this point, we've missed soft freeze.  Is this something we are still
trying to get into 1.5, or is it okay to slip it to 1.6 where we can
feel more comfortable about having a solid review in place?  Ultimately,
it's the maintainer's call, but I'm personally leaning towards deferring
- libvirt has survived with HMP savevm long enough that another qemu
release without QMP savevm won't be the end of the world.  I'm also
hoping that the final product is clean enough that a distro could feel
comfortable with the idea of rebasing to 1.5 while still backporting the
QMP commands that go into 1.6.

> 
> changes from v1:
>     - patch for updating bdrv_snapshot_goto and bdrv_snapshot_list is split
>       into two patches
>     - fixes typos and grammar
>     - vm-snapshot-delete and vm-snapshot-load now returns an error also if
>       snapshot for delete or load not exists
>     - all error messages starts with uppercase and are without trailing dot
>     - updated error messages recording to comments

...at least the summary makes it sound like you made a good effort.  It
might also help to provide a bit of context on how we are planning on
tackling any merge conflicts regarding the algorithm for snapshot
lookup, and whether there are any rebase dependencies between your
series and Wenchao's.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]