From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/4] sh-pfc: sh73a0: Add VCCQ MC0 regulator
Date: Wed, 24 Apr 2013 22:25:47 +0000 [thread overview]
Message-ID: <51785BEB.9000109@cogentembedded.com> (raw)
In-Reply-To: <1366672585-9098-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hello.
On 25-04-2013 1:20, Laurent Pinchart wrote:
>>> +static void __sh73a0_vccq_mc0_enable(struct regulator_dev *reg, bool
>>> enable)
>> Skip the __ and the confusing name "_enable" for a function that
>> does both enable and disable.
>> Call it sh73a0_vccq_mc0_endisable is my suggestion.
Maybe sh73a0_vccq_mc0_control()?
> That's a weird name, but I can live with that.
Yep, the name is weird.
WBR, Sergei
prev parent reply other threads:[~2013-04-24 22:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 23:16 [PATCH 2/4] sh-pfc: sh73a0: Add VCCQ MC0 regulator Laurent Pinchart
2013-04-24 12:36 ` Linus Walleij
2013-04-24 21:20 ` Laurent Pinchart
2013-04-24 22:25 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51785BEB.9000109@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.