Re: [PATCH 0/3] scsi_debug: fix data integrity support

[Douglas Gilbert <dgilbert@interlog.com>]

On 13-04-21 05:17 AM, Akinobu Mita wrote:
> When I tried testing the data integrity support in scsi_debug on x86_32,
> I got CONFIG_DEBUG_HIGHMEM warnings and protection errors.  This was
> triggered due to misused kmap_atomic/kunmap_atomic.
>
> And then, while I was testing the fix of the above issue with several
> combination with module parameters dix and dif, I found that doing
> 'modprobe scsi_debug dif=0 dix=1' causes kernel crash.
>
> This patch set includes these fixes and cleanup which is related to data
> integrity support.
>
> Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
> Cc: Douglas Gilbert <dgilbert@interlog.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Cc: linux-scsi@vger.kernel.org
>
> Akinobu Mita (3):
>    scsi_debug: fix data integrity support on highmem machine
>    scsi_debug: fix NULL pointer dereference with parameters dif=0 dix=1
>    scsi_debug: simplify offset calculation for dif_storep
>
>   drivers/scsi/scsi_debug.c | 29 ++++++++++++-----------------
>   1 file changed, 12 insertions(+), 17 deletions(-)

Again, I'd like to see some feedback from Martin Petersen
on this set of patches. For my part, for this patch series
(1/3 to 3/3):

Acked-by: Douglas Gilbert <dgilbert@interlog.com>