All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Drivers: HID: fix warnings: from is u16 which never < 0
Date: Thu, 25 Apr 2013 09:21:02 +0800	[thread overview]
Message-ID: <517884FE.407@asianux.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1304241632560.29143@pobox.suse.cz>

On 2013年04月24日 22:33, Jiri Kosina wrote:
> On Sun, 7 Apr 2013, Chen Gang wrote:
> 
>> > 
>> >   from is u16 which never < 0.
>> > 
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> > ---
>> >  drivers/hid/hid-icade.c |    2 +-
>> >  1 files changed, 1 insertions(+), 1 deletions(-)
>> > 
>> > diff --git a/drivers/hid/hid-icade.c b/drivers/hid/hid-icade.c
>> > index 09dcc04..76b5a75 100644
>> > --- a/drivers/hid/hid-icade.c
>> > +++ b/drivers/hid/hid-icade.c
>> > @@ -159,7 +159,7 @@ static const struct icade_key icade_usage_table[30] = {
>> >  
>> >  static const struct icade_key *icade_find_translation(u16 from)
>> >  {
>> > -	if (from < 0 || from > ICADE_MAX_USAGE)
>> > +	if (from > ICADE_MAX_USAGE)
>> >  		return NULL;
>> >  	return &icade_usage_table[from];
>> >  }
> Applied, thanks.

Thanks, too.

-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2013-04-25  1:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-07  4:55 [PATCH] Drivers: HID: fix warnings: from is u16 which never < 0 Chen Gang
2013-04-24 14:33 ` Jiri Kosina
2013-04-25  1:21   ` Chen Gang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517884FE.407@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.