From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVBdw-0003eH-41 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 22:10:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVBdr-0001BF-4o for qemu-devel@nongnu.org; Wed, 24 Apr 2013 22:10:39 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:59143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVBdq-0001Az-In for qemu-devel@nongnu.org; Wed, 24 Apr 2013 22:10:35 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Apr 2013 12:02:46 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id C25AA3578050 for ; Thu, 25 Apr 2013 12:10:19 +1000 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3P2ACIS13697200 for ; Thu, 25 Apr 2013 12:10:13 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3P2AIVl021482 for ; Thu, 25 Apr 2013 12:10:18 +1000 Message-ID: <51789081.70600@linux.vnet.ibm.com> Date: Thu, 25 Apr 2013 10:10:09 +0800 From: Lei Li MIME-Version: 1.0 References: <1366798350-27068-1-git-send-email-lilei@linux.vnet.ibm.com> <5177F21A.6050406@redhat.com> In-Reply-To: <5177F21A.6050406@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3 v3] Support for LED state extension to Qemu VNC server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: lagarcia@br.ibm.com, aliguori@us.ibm.com, qemu-devel@nongnu.org On 04/24/2013 10:54 PM, Eric Blake wrote: > On 04/24/2013 04:12 AM, Lei Li wrote: >> Hi guys, >> >> This patch series tries to add support for LED state >> extension to Qemu VNC server. The proposal has been sent >> few days ago as link below: >> >> http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html >> >> The previous version as link: >> >> http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03988.html >> >> Pleae let me know if there is anything else need be improved. > Can you fix your setup to include a series diffstat in your cover > letter? I know that 'git send-email --cover-letter --annotate' does > this; but I also know that's not the workflow everyone uses. I just > updated http://wiki.qemu.org/Contribute/SubmitAPatch to mention that a > cover letter diffstat is a useful review aid (I'd much rather check a > 0/n letter to see what files are touched in summary, rather than opening > n emails just to see if it touches any file I care about). I guess that > means I'm asking for a bit of help in further updating the wiki to > mention how to have git reliably include a cover letter diffstat, since > asking for something without giving a recipe of how to accomplish it > isn't very nice. Hi Eric, Sure, I will include the series diffstat. Thanks for your good suggestion! > -- Lei