From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVDGD-0008D7-0n for qemu-devel@nongnu.org; Wed, 24 Apr 2013 23:54:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVDG8-0008U8-EG for qemu-devel@nongnu.org; Wed, 24 Apr 2013 23:54:16 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:58982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVDG7-0008Tt-T3 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 23:54:12 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Apr 2013 09:19:07 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 93CC61258023 for ; Thu, 25 Apr 2013 09:25:39 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3P3runM2490706 for ; Thu, 25 Apr 2013 09:23:56 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3P3s2fV028586 for ; Thu, 25 Apr 2013 13:54:02 +1000 Message-ID: <5178A8D1.9040704@linux.vnet.ibm.com> Date: Thu, 25 Apr 2013 11:53:53 +0800 From: Lei Li MIME-Version: 1.0 References: <1366798350-27068-1-git-send-email-lilei@linux.vnet.ibm.com> <1366798350-27068-3-git-send-email-lilei@linux.vnet.ibm.com> <5177C5A1.4050109@redhat.com> In-Reply-To: <5177C5A1.4050109@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: lagarcia@br.ibm.com, aliguori@us.ibm.com, qemu-devel@nongnu.org On 04/24/2013 07:44 PM, Gerd Hoffmann wrote: > Hi, > >> + case VNC_ENCODING_LED_STATE: >> + vs->features |= VNC_FEATURE_LED_STATE_MASK; >> + break; > I think it with the client supporting the led state extension it is > probably a good idea to turn off the lock state sync logic in qemu's vnc > server, i.e. add a "!(vs->features & VNC_FEATURE_LED_STATE_MASK)" check > next to the lock_key_sync checks in do_key_event(). > > cheers, > Gerd Hi Gerd, Yes, I think it's a good idea. Thanks! > -- Lei