From: Qiang Huang <h.huangqiang@huawei.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>,
zhangwei <jovi.zhangwei@huawei.com>
Subject: [PATCH] sched: don't clear PF_THREAD_BOUND in select_fallback_rq
Date: Thu, 25 Apr 2013 17:01:18 +0800 [thread overview]
Message-ID: <5178F0DE.8030808@huawei.com> (raw)
This is revert of "sched-clear-pf-thread-bound-on-fallback-rq.patch"
(commit 0d939066acdcb in v3.4-rt),.
Select_fallback_rq() can be easilly called during system boot, because
select_task_rq_fair() just return task_cpu(p) for bounded kernel threads,
which is 0 during system boot and not in tsk_cpus_allowed, so
select_fallback_rq() is called and PF_THREAD_BOUND is cleared. In my
box, 1/3 bounded kernel threads will clear that flag after boot.
And it will cause problems, for example:
# for pid in `ps -e -o pid`; do taskset -p -c 0-15 $pid; done
this command will cause system hung.
What's more, I don't see why we need to clear this flag any more,
because "cpu/rt: Rework cpu down for PREEMPT_RT" already remove the
optimization for PF_THREAD_BOUND on migrate_disable/enable.
Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
---
kernel/sched/core.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 751ec60..8db6e3b 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1327,12 +1327,6 @@ out:
}
}
- /*
- * Clear PF_THREAD_BOUND, otherwise we wreckage
- * migrate_disable/enable. See optimization for
- * PF_THREAD_BOUND tasks there.
- */
- p->flags &= ~PF_THREAD_BOUND;
return dest_cpu;
}
-- 1.7.1
next reply other threads:[~2013-04-25 9:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 9:01 Qiang Huang [this message]
2013-05-03 20:46 ` [PATCH] sched: don't clear PF_THREAD_BOUND in select_fallback_rq Sebastian Andrzej Siewior
2013-05-03 22:39 ` Luis Claudio R. Goncalves
2013-05-05 6:38 ` Qiang Huang
2013-05-05 14:44 ` Sven-Thorsten Dietrich
2013-05-06 0:49 ` Li Zefan
2013-05-06 10:44 ` Qiang Huang
2013-05-14 13:08 ` Luis Claudio R. Goncalves
2013-06-21 10:48 ` Sebastian Andrzej Siewior
2013-06-07 20:50 ` Sebastian Andrzej Siewior
2013-06-07 20:59 ` Sebastian Andrzej Siewior
2013-06-22 3:27 ` Qiang Huang
2013-06-28 11:57 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5178F0DE.8030808@huawei.com \
--to=h.huangqiang@huawei.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.