Re: [PATCH v6 2/2] xl: Add commands for usb hot-plug

[George Dunlap <george.dunlap@eu.citrix.com>]

On 04/25/2013 12:57 PM, George Dunlap wrote:
> On 04/25/2013 12:38 PM, Ian Campbell wrote:
>> On Thu, 2013-04-25 at 11:16 +0100, George Dunlap wrote:
>>>>> +    for (i = 0; i < num; i++) {
>>>>> +        printf("%8s  ", (dev[i].protocol==LIBXL_USB_PROTOCOL_PV)?"pv":"dm");
>>>>
>>>> You can use libxl_usb_protocol_to_string here.
>>>
>>> Could do, but I didn't necessarily want the long version ("devicemodel").
>>
>> TBH the more I think about it the more I think DM/DEVICEMODEL in this
>> interface is leaking an implementation detail, after all the user
>> doesn't really care who/what is emulating a USB controller.
>>
>> Protocol = {PV,OHCI,XHCI}?
>
> As we covered before:
>
> 1. I have no way of selecting OHCI vs XHCI at this point
>
> 2. Even if I did, why should the caller have to keep track of what kind
> of USB hardware is exposed to the guest?  They should be able to just
> say "Add" and have stuff sorted out.
>
> In addition:
>
> 3. The point of saying DEVICEMODEL is that it's not PV.  An HVM guest
> may be able to do either, and should be allowed to choose.

If your problem is with the name, we could call it EMULATED instead.

  -George