All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liu Yuan <namei.unix@gmail.com>
To: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Cc: kwolf@redhat.com, sheepdog@lists.wpkg.org, qemu-devel@nongnu.org,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [sheepdog] [PATCH 3/3] sheepdog: resend write requests when SD_RES_READONLY is received
Date: Thu, 25 Apr 2013 21:08:01 +0800	[thread overview]
Message-ID: <51792AB1.7040301@gmail.com> (raw)
In-Reply-To: <1366886263-21263-4-git-send-email-morita.kazutaka@lab.ntt.co.jp>

On 04/25/2013 06:37 PM, MORITA Kazutaka wrote:
> +/* update inode with the latest state */
> +static int coroutine_fn reload_vdi_object(BDRVSheepdogState *s)

I'd suggest function name as
'reload_inode(BDRVSheepdogState *s, tag, snapid)', then sd_create_branch
and sd_snapshot_goto can make use of this function. With this change, it
would be conflicted to my patch series applied to Stefan's block tree +
Fix loadvm patch. So it would be better you can develop this patch set
against Stefan's block tree + my fix loadvm patch.

Others looks good to me.

Thanks,
Yuan

  reply	other threads:[~2013-04-25 13:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 10:37 [Qemu-devel] [PATCH 0/3] sheepdog: support online snapshot from qemu-img MORITA Kazutaka
2013-04-25 10:37 ` [Qemu-devel] [PATCH 1/3] sheepdog: cleanup find_vdi_name MORITA Kazutaka
2013-04-25 10:37 ` [Qemu-devel] [PATCH 2/3] sheepdog: add SD_RES_READONLY result code MORITA Kazutaka
2013-04-25 10:37 ` [Qemu-devel] [PATCH 3/3] sheepdog: resend write requests when SD_RES_READONLY is received MORITA Kazutaka
2013-04-25 13:08   ` Liu Yuan [this message]
2013-04-25 16:16     ` [Qemu-devel] [sheepdog] " MORITA Kazutaka
2013-04-25 13:56   ` [Qemu-devel] " Stefan Hajnoczi
2013-04-25 13:44 ` [Qemu-devel] [PATCH 0/3] sheepdog: support online snapshot from qemu-img Eric Blake
2013-04-25 14:01   ` [Qemu-devel] [sheepdog] " Liu Yuan
2013-04-25 14:06   ` [Qemu-devel] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51792AB1.7040301@gmail.com \
    --to=namei.unix@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=morita.kazutaka@lab.ntt.co.jp \
    --cc=qemu-devel@nongnu.org \
    --cc=sheepdog@lists.wpkg.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.