From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37610)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UVMLw-0006Tz-EM
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:36:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UVMLp-0001Ju-QA
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:36:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7541)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UVMLp-0001JX-Iw
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:36:41 -0400
Message-ID: <517931E6.1060709@redhat.com>
Date: Thu, 25 Apr 2013 15:38:46 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <20130425064701.GA9899@mail.duskware.de>
	<51790742.1050906@twiddle.net>
In-Reply-To: <51790742.1050906@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Git head build problem (popcountl vs. system
	headers)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Martin Husemann <martin@duskware.de>, qemu-devel@nongnu.org

On 04/25/13 12:36, Richard Henderson wrote:
> On 2013-04-25 07:47, Martin Husemann wrote:
>> I just tried building git HEAD on NetBSD-current and gcc chokes on
>> a prototype mismatch for popcountl:
>>
>> util/hbitmap.c has:
>>
>> static inline int popcountl(unsigned long l)
>> {
>>      return BITS_PER_LONG == 32 ? ctpop32(l) : ctpop64(l);
>> }
>>
>> while NetBSD's strings.h uses:
>>
>> unsigned int        popcountl(unsigned long) __constfunc;
> 
> <strings.h> is the K&R header supplanted by ISO <string.h>.
> Is there any good reason that we're including it at all?

- <strings.h> is a portable SUS/POSIX header:

http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/strings.h.html

- "popcountl()" in NetBSD's <strings.h> is either a
standards-nonconformance issue, or the the qemu build system doesn't set
up the right SUS/POSIX environment for compilation on NetBSD. (If that's
possible at all, I don't know.)

Laszlo