All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Tinguely <tinguely@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: xfs: fallback to vmalloc for large buffers in xfs_compat_attrlist_by_handle
Date: Thu, 25 Apr 2013 11:43:37 -0500	[thread overview]
Message-ID: <51795D39.70000@sgi.com> (raw)
In-Reply-To: <51795612.3080806@sandeen.net>

On 04/25/13 11:13, Eric Sandeen wrote:
> Shamelessly copied from dchinner's:
> ad650f5b xfs: fallback to vmalloc for large buffers in xfs_attrmulti_attr_get
>
> xfsdump uses a large buffer for extended attributes, which has a
> kmalloc'd shadow buffer in the kernel. This can fail after the
> system has been running for some time as it is a high order
> allocation. Add a fallback to vmalloc so that it doesn't require
> contiguous memory and so won't randomly fail while xfsdump is
> running.
>
> This was done for xfs_attrlist_by_handle but
> xfs_compat_attrlist_by_handle (the 32-bit version) needs the same
> attention.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---

Looks shamelessly good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-04-25 16:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 22:52 xfsdump having problems dumping attributes again (cannot allocate memory) Linda Walsh
2013-04-04  3:39 ` Linda Walsh
2013-04-04  3:52 ` Dave Chinner
2013-04-04  5:05   ` [PATCH] xfs: xfs: fallback to vmalloc for large buffers in xfs_attrlist_by_handle Eric Sandeen
2013-04-04  6:57     ` Linda Walsh
2013-04-16 13:37     ` Mark Tinguely
2013-04-25 16:13     ` [PATCH] xfs: xfs: fallback to vmalloc for large buffers in xfs_compat_attrlist_by_handle Eric Sandeen
2013-04-25 16:43       ` Mark Tinguely [this message]
2013-05-08  0:01       ` Ben Myers
2013-05-08  0:01     ` [PATCH] xfs: xfs: fallback to vmalloc for large buffers in xfs_attrlist_by_handle Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51795D39.70000@sgi.com \
    --to=tinguely@sgi.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.