From: "Mathias Fröhlich" <Mathias.Froehlich@gmx.net>
To: Christian Koenig <christian.koenig@amd.com>,
alexander.deucher@amd.com,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: An other radeon ring count patch
Date: Wed, 23 Apr 2014 08:49:04 +0200 [thread overview]
Message-ID: <51797156.q8Ca4oeqjx@notebook.internal> (raw)
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
Hi Christian, Alex,
While looking over the rest of the ring counts
I noticed an other one, this time we reserve too
much which cannot even be a potential problem.
Anyway, it's nicer to be correct.
Attached that patch to uvd_v1_0_ring_test()
Greetings
Mathias
[-- Attachment #2: 0001-drm-radeon-fix-count-in-uvd_v1_0_ring_test.patch --]
[-- Type: text/x-patch, Size: 1066 bytes --]
>From 889f02196e1a3a571aac8e878574e48a7469cb42 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mathias=20Fr=C3=B6hlich?= <Mathias.Froehlich@gmx.net>
Date: Wed, 23 Apr 2014 08:37:12 +0200
Subject: [PATCH] drm/radeon: fix count in uvd_v1_0_ring_test()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Should be 2 rather than 3.
Signed-off-by: Mathias Fröhlich <Mathias.Froehlich@gmx.net>
---
drivers/gpu/drm/radeon/uvd_v1_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/uvd_v1_0.c b/drivers/gpu/drm/radeon/uvd_v1_0.c
index 0a243f0..d50f510 100644
--- a/drivers/gpu/drm/radeon/uvd_v1_0.c
+++ b/drivers/gpu/drm/radeon/uvd_v1_0.c
@@ -320,7 +320,7 @@ int uvd_v1_0_ring_test(struct radeon_device *rdev, struct radeon_ring *ring)
int r;
WREG32(UVD_CONTEXT_ID, 0xCAFEDEAD);
- r = radeon_ring_lock(rdev, ring, 3);
+ r = radeon_ring_lock(rdev, ring, 2);
if (r) {
DRM_ERROR("radeon: cp failed to lock ring %d (%d).\n",
ring->idx, r);
--
1.9.0
[-- Attachment #3: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2014-04-23 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 6:49 Mathias Fröhlich [this message]
2014-04-28 14:18 ` An other radeon ring count patch Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51797156.q8Ca4oeqjx@notebook.internal \
--to=mathias.froehlich@gmx.net \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.