From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Matthew Whitehead <tedheadster@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] 3c509.c: call SET_NETDEV_DEV for all device types (ISA/ISAPnP/EISA)
Date: Fri, 26 Apr 2013 01:03:53 +0400 [thread overview]
Message-ID: <51799A39.6070002@cogentembedded.com> (raw)
In-Reply-To: <1366921743-6440-1-git-send-email-tedheadster@gmail.com>
Hello.
On 26-04-2013 0:29, Matthew Whitehead wrote:
> From: Matthew Whitehead <tedheadster@gmail.com>
> The venerable 3c509 driver only sets its device parent in one case, the ISAPnP one.
> It does this with the SET_NETDEV_DEV function. It should register with the device
> hierarchy in two additional cases: standard (non-PnP) ISA and EISA.
> - Currently they appear here:
> /sys/devices/virtual/net/eth0 (standard ISA)
> /sys/devices/virtual/net/eth1 (EISA)
> - Rather, they should instead be here:
> /sys/devices/isa/3c509.0/net/eth0 (standard ISA)
> /sys/devices/pci0000:00/0000:00:07.0/00:04/net/eth1 (EISA)
> Tested on ISA and EISA boards.
That's good but you forgot to sign off, so the patch can't be applied.
BTW, it seems that after almost 7 years I seem to have found a tester for
my patch which lingered all this time in the Andrew Morton's tree! You've said
you have EISA boards, how about testing my patch? Now if I could find Andrew
Morton's tree... Andrew?
The patch is for 3c59x.c however -- I've just realized the difference.
Just in case, here's the link to 2008 version of it:
http://marc.info/?l=linux-netdev&m=121744737806819
WBR, Sergei
next prev parent reply other threads:[~2013-04-25 21:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 20:29 [PATCH] 3c509.c: call SET_NETDEV_DEV for all device types (ISA/ISAPnP/EISA) Matthew Whitehead
2013-04-25 21:03 ` Sergei Shtylyov [this message]
2013-04-25 21:24 ` Sergei Shtylyov
2013-04-25 21:30 ` Andrew Morton
2013-04-25 21:37 ` Sergei Shtylyov
2013-04-25 22:10 ` Sergei Shtylyov
2013-04-25 21:25 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2013-04-29 21:46 Matthew Whitehead
2013-04-30 19:33 ` David Miller
2013-04-23 17:49 Matthew Whitehead
2013-04-25 5:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51799A39.6070002@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=tedheadster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.