From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
To: Jan Schmidt <list.btrfs@jan-o-sch.net>
Cc: chris.mason@fusionio.com, linux-btrfs@vger.kernel.org,
wangshilong1991@gmail.com, dsterba@suse.cz
Subject: Re: [PATCH v4 1/3] Btrfs: split btrfs_qgroup_account_ref into four functions
Date: Fri, 26 Apr 2013 09:26:10 +0800 [thread overview]
Message-ID: <5179D7B2.2040005@cn.fujitsu.com> (raw)
In-Reply-To: <1366905892-7880-2-git-send-email-list.btrfs@jan-o-sch.net>
Hello Jan,
> The function is separated into a preparation part and the three accounting
> steps mentioned in the qgroups documentation. The goal is to make steps two
> and three usable by the rescan functionality. A side effect is that the
> function is restructured into readable subunits.
>
In fact, you only reuse step1 function, not step2,step3 function..
Otherwise, looks good to me.
Reviewed-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
next prev parent reply other threads:[~2013-04-26 1:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 16:04 [PATCH v4 0/3] Btrfs: quota rescan for 3.10 Jan Schmidt
2013-04-25 16:04 ` [PATCH v4 1/3] Btrfs: split btrfs_qgroup_account_ref into four functions Jan Schmidt
2013-04-26 1:26 ` Wang Shilong [this message]
2013-04-25 16:04 ` [PATCH v4 2/3] Btrfs: rescan for qgroups Jan Schmidt
2013-04-26 1:42 ` Wang Shilong
2013-05-01 7:29 ` Wang Shilong
2013-05-01 11:03 ` Jan Schmidt
2013-05-01 11:42 ` Wang Shilong
2013-05-01 11:57 ` Jan Schmidt
2013-04-25 16:04 ` [PATCH v4 3/3] Btrfs: automatic rescan after "quota enable" command Jan Schmidt
2013-04-26 15:29 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5179D7B2.2040005@cn.fujitsu.com \
--to=wangsl-fnst@cn.fujitsu.com \
--cc=chris.mason@fusionio.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.