From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ich9: kill cmos_s3
Date: Fri, 26 Apr 2013 10:38:41 +0200 [thread overview]
Message-ID: <517A3D11.9020702@redhat.com> (raw)
In-Reply-To: <5178291F.3090607@suse.de>
Il 24/04/2013 20:49, Andreas Färber ha scritto:
> Am 24.04.2013 13:30, schrieb Paolo Bonzini:
>> Il 24/04/2013 12:37, Hu Tao ha scritto:
>>> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
>>
>> I had exactly the same patch in my 1.6 queue. :)
>>
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
> The commit message fails to explain *why* we can drop updating whatever
> RTC memory value there though?
Ultimately the argument was unused (see the ich9_pm_init part of the
patch). This is now done with
s->suspend_notifier.notify = rtc_notify_suspend;
qemu_register_suspend_notifier(&s->suspend_notifier);
in hw/timer/mc146818rtc.c.
Paolo
next prev parent reply other threads:[~2013-04-26 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 10:37 [Qemu-devel] [PATCH] ich9: kill cmos_s3 Hu Tao
2013-04-24 11:30 ` Paolo Bonzini
2013-04-24 18:49 ` Andreas Färber
2013-04-26 8:38 ` Paolo Bonzini [this message]
2013-04-24 18:24 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517A3D11.9020702@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=hutao@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.