From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>, git@vger.kernel.org
Subject: Re: [PATCH] t9501: Do not use export X=Y
Date: Fri, 26 Apr 2013 11:21:39 +0200 [thread overview]
Message-ID: <517A4723.7050309@web.de> (raw)
In-Reply-To: <7va9om2v9z.fsf@alter.siamese.dyndns.org>
On 2013-04-25 22.46, Junio C Hamano wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> Spilt lines like export X=Y into 2 lines:
>> X=Y
>> export X
>
> That can be read from the patch text.
>
> If you are going to spend three lines, please describe why it has to
> be split; that would help educate developers new to the codebase.
>
So true,
writing good commit messages is not easy.
and this was a good example for a bad example
Side questions:
Which shells of which OS/distribution do not understand export X=Y?
next prev parent reply other threads:[~2013-04-26 9:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 18:49 [PATCH] t9501: Do not use export X=Y Torsten Bögershausen
2013-04-25 20:46 ` Junio C Hamano
2013-04-26 9:21 ` Torsten Bögershausen [this message]
2013-04-26 16:46 ` Junio C Hamano
2013-04-26 18:14 ` Rodrigo Campos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517A4723.7050309@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.