From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44417)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UVezI-00073V-Kk
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 05:30:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UVezF-0006PL-R1
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 05:30:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21037)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UVezF-0006Oz-KU
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 05:30:37 -0400
Message-ID: <517A49C2.9030506@redhat.com>
Date: Fri, 26 Apr 2013 11:32:50 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1366316544-1428-1-git-send-email-lersek@redhat.com>
	<1366316544-1428-4-git-send-email-lersek@redhat.com>
	<87zjwmjvlx.fsf@codemonkey.ws>
In-Reply-To: <87zjwmjvlx.fsf@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 3/7] hw/acpi: extract standard table
 headers as a standalone structure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, mst@redhat.com

On 04/25/13 20:47, Anthony Liguori wrote:
> Laszlo Ersek <lersek@redhat.com> writes:

>> +typedef struct acpi_table_std_header {
>> +    char sig[4];              /* ACPI signature (4 ASCII characters) */
>> +    uint32_t length;          /* Length of table, in bytes, including header */
>> +    uint8_t revision;         /* ACPI Specification minor version # */
>> +    uint8_t checksum;         /* To make sum of entire table == 0 */
>> +    char oem_id[6];           /* OEM identification */
>> +    char oem_table_id[8];     /* OEM table identification */
>> +    uint32_t oem_revision;    /* OEM revision number */
>> +    char asl_compiler_id[4];  /* ASL compiler vendor ID */
>> +    uint32_t asl_compiler_revision; /* ASL compiler revision number */
>> +} QEMU_PACKED AcpiTableStdHdr;
> 
> Since you're giving it a CamelCaseName why don't you do the same for the
> struct.  After that:

This was on purpose. The original "struct acpi_table_header" that I was
extracting from had lower_case_underscore_separated name. My impression
was that structure tags were named_like_this, while ordinary identifiers
denoting types were NamedLikeThis. I was trying to follow that.

However I can see now that in general that observation was wrong. I'll
fix it.

Thanks,
Laszlo