From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Scott Subject: Re: [PATCH v2] Only call stat() when adding a disk if we expect a device to exist. Date: Fri, 26 Apr 2013 12:07:09 +0100 Message-ID: <517A5FDD.6090309@eu.citrix.com> References: <1366711166-28296-1-git-send-email-dave.scott@eu.citrix.com> <517695F1.4000206@citrix.com> <1366804610.20256.300.camel@zakaz.uk.xensource.com> <1366973715.3142.66.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1366973715.3142.66.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org T24gMjYvMDQvMTMgMTE6NTUsIElhbiBDYW1wYmVsbCB3cm90ZToKPiBPbiBXZWQsIDIwMTMtMDQt MjQgYXQgMTI6NTYgKzAxMDAsIElhbiBDYW1wYmVsbCB3cm90ZToKPj4gT24gVHVlLCAyMDEzLTA0 LTIzIGF0IDE1OjA4ICswMTAwLCBSb2dlciBQYXUgTW9ubmUgd3JvdGU6Cj4+PiBPbiAyMy8wNC8x MyAxMTo1OSwgRGF2aWQgU2NvdHQgd3JvdGU6Cj4+Pj4gV2UgY29uc2lkZXIgY2FsbGluZyBzdGF0 KCkgYSBoZWxwZnVsIGVycm9yIGNoZWNrIGluIHRoZSBmb2xsb3dpbmcKPj4+PiBjaXJjdW1zdGFu Y2VzIG9ubHk6Cj4+Pj4gICAxLiB0aGUgZGlzayBiYWNrZW5kIHR5cGUgbXVzdCBiZSBQSFlzaWNh bAo+Pj4+ICAgMi4gdGhlIGRpc2sgYmFja2VuZCBkb21haW4gbXVzdCBiZSB0aGUgc2FtZSBhcyB0 aGUgcnVubmluZyBsaWJ4bAo+Pj4+ICAgICAgY29kZSAoaWUgTElCWExfVE9PTFNUQUNLX0RPTUlE KQo+Pj4+ICAgMy4gdGhlcmUgbXVzdCBub3QgYmUgYSBob3RwbHVnIHNjcmlwdCBiZWNhdXNlIHRo aXMgd291bGQgaW1wbHkgdGhhdAo+Pj4+ICAgICAgdGhlIGRldmljZSB3b24ndCBiZSBjcmVhdGVk IHVudGlsIGFmdGVyIHRoZSBob3RwbHVnIHNjcmlwdCBoYXMKPj4+PiAgICAgIHJ1bi4KPj4+Pgo+ Pj4+IFdpdGggdGhpcyBmaXgsIGl0IGlzIHBvc3NpYmxlIHRvIHVzZSBxZW11J3MgYnVpbHQtaW4g YmxvY2sgZHJpdmVycwo+Pj4+IHN1Y2ggYXMgY2VwaC9yYmQsIHdpdGggYSB4bCBjb25maWcgZGlz ayBzcGVjIGxpa2UgdGhpczoKPj4+Pgo+Pj4+IGRpc2s9WyAnYmFja2VuZHR5cGU9cWRpc2ssZm9y bWF0PXJhdyx2ZGV2PWhkYSxhY2Nlc3M9cncsdGFyZ2V0PXJiZDpyYmQvdWJ1bnR1MTIwNC5pbWcn IF0KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IERhdmlkIFNjb3R0IDxkYXZlLnNjb3R0QGV1LmNp dHJpeC5jb20+Cj4+Pj4gQWNrZWQtYnk6IElhbiBDYW1wYmVsbCA8aWFuLmNhbXBiZWxsQGNpdHJp eC5jb20+Cj4+Pgo+Pj4gQWNrZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRy aXguY29tPgo+Pgo+PiBBcHBsaWVkLCB0aGFua3MuCj4KPiBUaGlzIHBhdGNoIGhhZCB0aGUgc2xp Z2h0bHkgdW5mb3J0dW5hdGUgaW1wYWN0IG9mIGNhdXNpbmcgbGlieGwgdG8gbm90Cj4gdXNlIGJs a2JhY2sgZm9yIGFjdHVhbCBibG9jayBkZXZpY2VzIHByZXNlbnQgaW4gZG9tMCwgY2F1c2luZyBp dCB0byBmYWxsCj4gYmFjayB0byB0YXAvcWVtdS4KPgo+IEknbSBoYXZpbmcgYSBsb29rIG5vdy4u LgoKVGhhbmtzIChhbmQgc29ycnkhKQoKTG9va2luZyBhdCB0aGUgY29kZSBhZ2FpbiwgaXMgaXQg YmVjYXVzZSBieXBhc3NpbmcgdGhlIHN0YXQoKSBpbiB0aGUgClVOS05PV04gY2FzZSB3aGVyZSBp biBmYWN0IGl0IGlzIGEgYmxvY2sgZGV2aWNlLCBsZWF2ZXMgYS5zdGFiIAp1bmluaXRpYWxpc2Vk IHdoaWNoIHRoZW4gY29uZnVzZXMKCiAgICAgICAgIGlmIChsaWJ4bF9fdHJ5X3BoeV9iYWNrZW5k KGEtPnN0YWIuc3RfbW9kZSkpCiAgICAgICAgICAgICByZXR1cm4gYmFja2VuZDsKCmluIGRpc2tf dHJ5X2JhY2tlbmQ/CgpQZXJoYXBzIGEgYmV0dGVyIHBhdGNoIHdvdWxkIGRvIHRoZSBzdGF0KCkg YW55d2F5IGFuZCBvbmx5IHdvcnJ5IGFib3V0IAp0aGUgZmFpbHVyZSBpZiAoZGlzay0+YmFja2Vu ZCA9IC4uLiBQSFkgJiYgZGlzay0+YmFja2VuZF9kb21pZCA9IC4uLiBldGMpCgoKQ2hlZXJzLApE YXZlCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4t ZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54 ZW4ub3JnL3hlbi1kZXZlbAo=