From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Marczykowski Subject: bug in xc_gntshr_munmap? Date: Fri, 26 Apr 2013 13:07:19 +0200 Message-ID: <517A5FE7.9050904@invisiblethingslab.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7645950504818710276==" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============7645950504818710276== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigCDED4DEA51631DACC995086C" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCDED4DEA51631DACC995086C Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, Header says: /* * Unmaps the @count pages starting at @start_address, which were mapped = by a * call to xc_gntshr_share_*. Never logs. */ int xc_gntshr_munmap(xc_gntshr *xcg, void *start_address, uint32_t count)= ; But implementation calls: static int linux_gntshr_munmap(xc_gntshr *xcg, xc_osdep_handle h, void *start_address, uint32_t count) { return munmap(start_address, count); } munmap(2) expect second argument to be size of mapped area (in bytes), no= t pages count. Users of xc_gntshr_munmap (the only one I'm aware of is libxenvchan) alre= ady uses that broken semantic. Is it going to be fixed (I can send trivial patch for both libxc and libxenvchan), or the comment in header should be updated? --=20 Best Regards / Pozdrawiam, Marek Marczykowski Invisible Things Lab --------------enigCDED4DEA51631DACC995086C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJRel/oAAoJENuP0xzK19cs17AH/im9ls4ZAhhdyJetLADsU0ft f0EH07jr1TJLGxl3XjNsa81le9PioW6aSGVmCPhYwsVrcXQ3mGUXeBWNLWCMgheJ yyzYKS46Gp0y4Bx73elYcaQNdpxgJcaGRXgOx0ibm0pP1VA5o1iwsTx2OrRqcbvC j5zh0krTn+Za7bNSQ+Otu5cGwbPYuOizrN3iyA3g0hF/ZeGvxdwVMjiA6jPWW9/l fVKnVtuYJAhq3KJtU08pDx6VFI67EphB0+kK9Gx9DqqYvQxuZyW8gA2JNib8VQX5 Qk1OolLM/BudWHSA7wFFx5mSpDuG6GwIICgFpyXoZEuwxwBrzL2s29FqIwOnBvQ= =An0A -----END PGP SIGNATURE----- --------------enigCDED4DEA51631DACC995086C-- --===============7645950504818710276== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7645950504818710276==--