From: Laszlo Ersek <lersek@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio: abort on zero config length
Date: Fri, 26 Apr 2013 13:33:50 +0200 [thread overview]
Message-ID: <517A661E.1000309@redhat.com> (raw)
In-Reply-To: <517A57AB.60804@redhat.com>
On 04/26/13 12:32, Eric Blake wrote:
> On 04/25/2013 11:06 PM, Jason Wang wrote:
>>>> if (addr > (vdev->config_len - sizeof(val)))
>>>>
>>>> ^^^^^^^^^ quiz: spot a bug above if config_len is 0 :)
>>> Then we need to fix these bugs and allocate a CVE. virtio-rng has
>>> shipped. This code is also dumb.
>>
>> Ok, but since the discussion is in public list, no need for CVE then.
>
> Wrong. CVEs are useful even for publicly disclosed bugs. It tells
> people whether they need to upgrade in order to avoid a vulnerability.
Small addition (since my English parser turns "whether" into "whether or
not"): a CVE tells people *that* (not "if") they should upgrade. Lack of
a CVE mention in a commit doesn't imply -- at least in, ugh, another big
project -- that the fix is without security consequences ("no CVE fix, I
don't need it").
(Apologies for hair-splitting.)
Laszlo
prev parent reply other threads:[~2013-04-26 11:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 7:43 [Qemu-devel] [PATCH] virtio: abort on zero config length Jason Wang
2013-04-25 8:11 ` Michael S. Tsirkin
2013-04-25 20:20 ` Anthony Liguori
2013-04-25 21:02 ` Michael S. Tsirkin
2013-04-25 22:27 ` Anthony Liguori
2013-04-26 5:06 ` Jason Wang
2013-04-26 10:32 ` Eric Blake
2013-04-26 10:33 ` Jason Wang
2013-04-26 12:31 ` Michael S. Tsirkin
2013-04-26 14:13 ` Anthony Liguori
2013-04-26 11:33 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517A661E.1000309@redhat.com \
--to=lersek@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.