From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVjJw-0002HA-Hw for qemu-devel@nongnu.org; Fri, 26 Apr 2013 10:08:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVjJu-0002ZU-MZ for qemu-devel@nongnu.org; Fri, 26 Apr 2013 10:08:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVjJu-0002ZM-FY for qemu-devel@nongnu.org; Fri, 26 Apr 2013 10:08:14 -0400 Message-ID: <517A8A46.4010408@redhat.com> Date: Fri, 26 Apr 2013 08:08:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <20130421191129.8947.77964.stgit@fimbulvetr.bsc.es> <20130421191248.8947.60085.stgit@fimbulvetr.bsc.es> In-Reply-To: <20130421191248.8947.60085.stgit@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2UFMGULDICOPKONFMAFSS" Subject: Re: [Qemu-devel] [PATCH v3 14/24] instrument: Add internal control interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2UFMGULDICOPKONFMAFSS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/21/2013 01:12 PM, Llu=C3=ADs Vilanova wrote: > This interface provides two sets of operations: >=20 > * Loading/unloading a trace instrumentation library. >=20 > * Controls the instrumentation callbacks of the tracing events. >=20 > Note that in the case of static instrumentation, the library is not > loaded/unloaded, but is still properly (de)initialized when QEMU starts= and > exits. I don't know if the series in general will be accepted, but if so, here's some interface things to think about: > +++ b/instrument/qapi-schema.json > @@ -0,0 +1,26 @@ > +# *-*- Mode: Python -*-* > +# > +# QAPI trace instrumentation control commands. > +# > +# Copyright (C) 2012-2013 Llu=C3=ADs Vilanova > +# > +# This work is licensed under the terms of the GNU GPL, version 2 or l= ater. > +# See the COPYING file in the top-level directory. > + > +## > +# @InstrType > +# > +# Instrumentation type supported by the system. > +# > +# @None: No instrumentation support. > +# > +# @Static: Static instrumentation support. > +# > +# @Dynamic: Dynamic instrumentation support. Generally, QMP enums are lower case (s/None/none/, and so forth). > +# > +# Warning: Keep in sync with #QIType. If we had the hypothetical tool that converted .json into end-user documentation, this sort of comment does not belong in the end-user document. Do we need to invent a syntax for development-only comments within .json files for things that are useful during qemu development? Or is it just better to move the comment to instead be in the C file that declares the enum, reminding any developer that modifies the enum to also modify the QMP type that reflects it? (We went with the latter approach in the recent query-command-line-options, putting the reminder comment to keep QMP and C in sync only in the C file.) > +# > +# Since: 1.5 This missed 1.5; it will need to be 1.6 now. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2UFMGULDICOPKONFMAFSS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJReopHAAoJEKeha0olJ0Nq0REH/iDVmqn//ZIOMmjDMb3pfvOH A4sR4cHDGuXHUSJUf3m0cA1UX5TJ3dLrzATmrARjN5GZftcqH7xgriMgRf/cjkCx oAvy0tHxce/XBYq1I4ei+sXJYBppM6q7HZOGBDVQiw6jIT9nDfWb0Mo2Ie5Hf1Ot K3mfvbWYRCbejpceX9LAWGGdBob8mI29h9MOpUz9yVR675Q/ZW9jsoXClTEMZYus ui3YEbc5yPY7KQBoLGesrxvQ/MTPSxw0QPApuGtvve739pSZa4wJp1wzwrfYHE9L lh+Wi8fhiBo+pNBwIcy1DmIL0A+O/tcUGn4moxqS2I1dpkqGbLFBD+NWjQi0sPY= =8ss+ -----END PGP SIGNATURE----- ------enig2UFMGULDICOPKONFMAFSS--