All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	Jim Fehlig <jfehlig@suse.com>,
	Dave Scott <Dave.Scott@eu.citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: libvirt, libxl and QDISKs
Date: Fri, 26 Apr 2013 16:36:49 +0200	[thread overview]
Message-ID: <517A9101.6080803@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1304261108000.4180@kaball.uk.xensource.com>

On 26/04/13 12:10, Stefano Stabellini wrote:
> On Fri, 26 Apr 2013, Jim Fehlig wrote:
>>     if (l_disk->driverName) {
>>         if (STREQ(l_disk->driverName, "tap") ||
>>             STREQ(l_disk->driverName, "tap2")) {
>>             switch (l_disk->format) {
>>             case VIR_STORAGE_FILE_QCOW:
>>                 x_disk->format = LIBXL_DISK_FORMAT_QCOW;
>>                 x_disk->backend = LIBXL_DISK_BACKEND_QDISK;
>>                 break;
>>             case VIR_STORAGE_FILE_QCOW2:
>>                 x_disk->format = LIBXL_DISK_FORMAT_QCOW2;
>>                 x_disk->backend = LIBXL_DISK_BACKEND_QDISK;
>>                 break;
>>             case VIR_STORAGE_FILE_VHD:
>>                 x_disk->format = LIBXL_DISK_FORMAT_VHD;
>>                 x_disk->backend = LIBXL_DISK_BACKEND_TAP;
>>                 break;
>>             case VIR_STORAGE_FILE_NONE:
>>                 /* No subtype specified, default to raw/tap */
>>             case VIR_STORAGE_FILE_RAW:
>>                 x_disk->format = LIBXL_DISK_FORMAT_RAW;
>>                 x_disk->backend = LIBXL_DISK_BACKEND_TAP;
>>                 break;
>>             default:
>>                 virReportError(VIR_ERR_INTERNAL_ERROR,
>>                                _("libxenlight does not support disk
>> driver %s"),
>>                               
>> virStorageFileFormatTypeToString(l_disk->format));
>>                 return -1;
>>             }
>>         } else if (STREQ(l_disk->driverName, "file")) {
>>             x_disk->format = LIBXL_DISK_FORMAT_RAW;
>>             x_disk->backend = LIBXL_DISK_BACKEND_TAP;
>>         } else if (STREQ(l_disk->driverName, "phy")) {
>>             x_disk->format = LIBXL_DISK_FORMAT_RAW;
>>             x_disk->backend = LIBXL_DISK_BACKEND_PHY;
>>         } else {
>>             virReportError(VIR_ERR_INTERNAL_ERROR,
>>                            _("libxenlight does not support disk driver %s"),
>>                            l_disk->driverName);
>>             return -1;
>>         }
>>     } else {
>>         /*
>>          * If driverName is not specified, default to raw as per
>>          * xl-disk-configuration.txt in the xen documentation and let
>>          * libxl pick a suitable backend.
>>          */
>>         x_disk->format = LIBXL_DISK_FORMAT_RAW;
>>         x_disk->backend = LIBXL_DISK_BACKEND_UNKNOWN;
>>     }
> 
> It looks like the defaults are the same of libxl.
> 
> However the mapping of RAW to TAP (libxl does the same) has always been
> a bit dubious to me: now that upstream QEMU is used with HVM guests too
> by libxl, there is no reason to use blktap over QEMU for raw files any
> more.

Qemu should indeed be much faster than blktap when using recent Linux
kernels in the DomU due to persistent grants, I don't think blktap can
provide the same performance, although I have not tested it. With Qemu
we can get 900k IOPS.

http://xenbits.xen.org/people/royger/persistent_read_qemu.png

  parent reply	other threads:[~2013-04-26 14:36 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-24 14:22 libvirt, libxl and QDISKs David Scott
2013-04-24 15:55 ` Stefano Stabellini
2013-04-25  8:55 ` Ian Campbell
2013-04-25 10:36   ` George Dunlap
2013-04-25 11:33     ` Ian Campbell
2013-04-25 11:55       ` Stefano Stabellini
2013-04-25 11:57         ` Ian Campbell
2013-04-25 12:12           ` David Scott
2013-04-25 12:43             ` Ian Campbell
2013-04-25 13:22               ` David Scott
2013-04-25 13:56                 ` Ian Campbell
2013-04-26  1:27                   ` Jim Fehlig
2013-04-26  4:50                     ` Jim Fehlig
2013-04-26 10:37                       ` David Scott
2013-04-26 23:44                         ` Jim Fehlig
     [not found]                         ` <517B1170.4020300@suse.com>
2013-04-29  9:41                           ` David Scott
2013-04-26  8:49                     ` Ian Campbell
2013-04-26 10:10                     ` Stefano Stabellini
2013-04-26 10:13                       ` Ian Campbell
2013-04-26 10:28                         ` Stefano Stabellini
2013-04-26 11:31                       ` Marek Marczykowski
2013-04-26 11:40                         ` Ian Campbell
2013-04-26 11:48                           ` Stefano Stabellini
2013-04-26 13:27                             ` Ian Campbell
2013-04-26 17:10                               ` Stefano Stabellini
2013-04-29  8:23                                 ` Ian Campbell
2013-04-29 10:07                                   ` Stefano Stabellini
2013-04-26 11:50                           ` Marek Marczykowski
2013-04-29 21:00                             ` Jim Fehlig
2013-04-26 11:45                         ` Stefano Stabellini
2013-04-26 14:36                       ` Roger Pau Monné [this message]
2013-04-25 18:26         ` Sylvain Munaut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517A9101.6080803@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=Dave.Scott@eu.citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=jfehlig@suse.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.