Re: BUG 4.2.2: xl cd-insert corrupts xenstore state

[George Dunlap <george.dunlap@eu.citrix.com>]

On 26/04/13 15:39, Ian Campbell wrote:
> On Fri, 2013-04-26 at 15:34 +0100, George Dunlap wrote:
>> $ git checkout RELEASE-4.2.2
>> $ git clean -ffdx
>>
>> [do a build, install, reboot]
>>
>> $ xl create a0
>>
>> $ xl cd-eject a0 hdc
>>
>> [However, the guest OS still sees the CD inserted]
>>
>> $ xl block-list a0
>> Segmentation fault
>>
>> $ xl cd-insert a0 hdc file:/images/xs-tools-6.0.0.iso
>> Segmentation fault
> Can you get a backtrace out of gdb?

Turns out I already fixed this once!

commit c3556e2a1aee3c9b7dda5d57e85e8867fff1b9da
Author: George Dunlap <george.dunlap@eu.citrix.com>
Commit: George Dunlap <george.dunlap@eu.citrix.com>

     libxl: Fix bug in libxl_cdrom_insert, make more robust against bad 
xenstore data

     libxl_cdrom_insert was failing to initialize the backend type,
     resulting in the wrong default backend.  The result was not only that
     the CD was not inserted properly, but also that some improper xenstore
     entries were created, causing further block commands to fail.

     This patch fixes the bug by setting the disk backend type based on the
     type of the existing device.

     It also makes the system more robust by checking to see that it has
     got a valid path before proceeding to write a partial xenstore entry.

     Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
     Acked-by: Ian Campbell <ian.campbell@citrix.com>
     Committed-by: Ian Campbell <ian.campbell@citrix.com>