From: Matt Fleming <matt.fleming@intel.com>
To: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"mjg59@srcf.ucam.org" <mjg59@srcf.ucam.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"jk@ozlabs.org" <jk@ozlabs.org>, "teg@jklm.no" <teg@jklm.no>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mikew@google.com" <mikew@google.com>,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/efi2] efivars: efivar_entry API
Date: Fri, 26 Apr 2013 15:55:08 +0100 [thread overview]
Message-ID: <517A954C.7060505@intel.com> (raw)
In-Reply-To: <A5ED84D3BB3A384992CBB9C77DEDA4D41AFD1E2B@USINDEM103.corp.hds.com>
On 26/04/13 15:25, Seiji Aguchi wrote:
> Matt,
>
> Thanks.
> With your patch, It works in case each entry is erased one by one as below.
> # rm dmesg-efi-1
> #rm dmesg-efi-2
How about if you add this to efi_pstore_erase_func()?
---
diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
index b820593..393d63a 100644
--- a/drivers/firmware/efi/efi-pstore.c
+++ b/drivers/firmware/efi/efi-pstore.c
@@ -166,6 +166,7 @@ static int efi_pstore_erase_func(struct efivar_entry *entry, void *data)
/* found */
__efivar_entry_delete(entry);
+ list_del(&entry->list);
return 1;
}
next prev parent reply other threads:[~2013-04-26 14:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-e14ab23dde12b80db4c94b684a2e485b72b16af3@git.kernel.org>
2013-04-23 23:55 ` [tip:x86/efi2] efivars: efivar_entry API Seiji Aguchi
2013-04-26 9:55 ` Matt Fleming
2013-04-26 14:25 ` Seiji Aguchi
2013-04-26 14:55 ` Matt Fleming [this message]
2013-04-26 15:05 ` Seiji Aguchi
2013-04-26 14:28 ` Seiji Aguchi
2013-04-26 14:35 ` Fleming, Matt
2013-04-26 14:37 ` Seiji Aguchi
2013-04-26 15:43 ` Seiji Aguchi
2013-04-30 11:27 ` Matt Fleming
2013-04-30 14:53 ` Seiji Aguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517A954C.7060505@intel.com \
--to=matt.fleming@intel.com \
--cc=hpa@zytor.com \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mikew@google.com \
--cc=mingo@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=seiji.aguchi@hds.com \
--cc=teg@jklm.no \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.