From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60812)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UVkZA-0002u3-72
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 11:28:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UVkZ6-0004RS-FK
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 11:28:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26635)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UVkZ6-0004RM-7O
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 11:28:00 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3QFRxDa002309
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 26 Apr 2013 11:27:59 -0400
Received: from yakj.usersys.redhat.com (ovpn-112-38.ams2.redhat.com
	[10.36.112.38])
	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id r3QFRww3011509
	for <qemu-devel@nongnu.org>; Fri, 26 Apr 2013 11:27:59 -0400
Message-ID: <517A9CF5.3020909@redhat.com>
Date: Fri, 26 Apr 2013 17:27:49 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20130421191129.8947.77964.stgit@fimbulvetr.bsc.es>
	<20130421191248.8947.60085.stgit@fimbulvetr.bsc.es>
	<517A9931.8010900@redhat.com> <87zjwlqpog.fsf@fimbulvetr.bsc.es>
In-Reply-To: <87zjwlqpog.fsf@fimbulvetr.bsc.es>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 14/24] instrument: Add internal control
 interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Il 26/04/2013 17:25, Llu=C3=ADs Vilanova ha scritto:
> Paolo Bonzini writes:
>=20
>> Il 21/04/2013 21:12, Llu=C3=ADs Vilanova ha scritto:
>>> diff --git a/Makefile.objs b/Makefile.objs
>>> index 5f8ea2d..4fb565b 100644
>>> --- a/Makefile.objs
>>> +++ b/Makefile.objs
>>> @@ -94,6 +94,7 @@ common-obj-y +=3D disas/
>>> # instrumentation
>>>
>>> tools-obj-y +=3D instrument/
>>> +target-obj-y +=3D instrument/
>>>
>=20
>> Why does instrument/ have to be compiled once per target?
>=20
>> If you can compile it just once, then libqemuutil.a and util-obj-y wil=
l do.
>=20
> It looks like that after some re-merges, the patch was placed too early=
 in the
> series. This is necessary later for files like instrument/cmdline.c and
> instrument/api-control.c (patch 18).

The point of using a static library is exactly to leave out files
automatically if they are not used.  Just put it into libqemuutil.a, and
tools will not pick it up.

Paolo