From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVkeN-00076i-9Z for qemu-devel@nongnu.org; Fri, 26 Apr 2013 11:33:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVkeF-00064X-Th for qemu-devel@nongnu.org; Fri, 26 Apr 2013 11:33:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33414 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVkeF-00064H-OH for qemu-devel@nongnu.org; Fri, 26 Apr 2013 11:33:19 -0400 Message-ID: <517A9E3E.2060901@suse.de> Date: Fri, 26 Apr 2013 17:33:18 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1366915386-14728-1-git-send-email-ehabkost@redhat.com> <1366915386-14728-8-git-send-email-ehabkost@redhat.com> <20130426171029.3e159116@thinkpad> <20130426153108.GX2900@otherpad.lan.raisama.net> In-Reply-To: <20130426153108.GX2900@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC 7/7] target-i386: Disable direct passthrough of PMU CPUID leaf by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Igor Mammedov , qemu-devel@nongnu.org, Gleb Natapov Am 26.04.2013 17:31, schrieb Eduardo Habkost: > On Fri, Apr 26, 2013 at 05:10:29PM +0200, Igor Mammedov wrote: >> On Thu, 25 Apr 2013 15:43:06 -0300 >> Eduardo Habkost wrote: >> >>> The current code handling the CPUID 0xA leaf simply forwards all data >>> from GET_SUPPORTED_CPUID directly to the guest, breaking migration >>> between hosts with different number of PMU counters. >>> >>> This patch disables this behavior, except on older machine-types (for >>> compatibility) and on the "host" CPU model. >> Please, make it static property and use compat properties. >> Result will be simpler and much less will have to be redone/discarded= after >> converting to the rest to properties and sub-classes. >=20 > I was going to say that static properties were too much work to be done > in time for 1.5, but you are right: in this specific case adding a > static property for the cpuid_pmu_passthrough field looks very easy. I > will give it a try. I am hoping to get as initial set (though not all) of the static properties still into 1.5. Using them to fix CPUID bugs can then be done during Hard Freeze. :) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg