From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVl5t-0002y5-3p for qemu-devel@nongnu.org; Fri, 26 Apr 2013 12:01:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVl5q-0006Mt-RC for qemu-devel@nongnu.org; Fri, 26 Apr 2013 12:01:52 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:35925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVl5q-0006Lp-Hm for qemu-devel@nongnu.org; Fri, 26 Apr 2013 12:01:50 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Apr 2013 16:58:05 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7A61E1B08067 for ; Fri, 26 Apr 2013 17:01:45 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3QG1Zxr44695552 for ; Fri, 26 Apr 2013 16:01:35 GMT Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3QG1jCW022183 for ; Fri, 26 Apr 2013 10:01:45 -0600 Message-ID: <517AA4E8.2000103@de.ibm.com> Date: Fri, 26 Apr 2013 18:01:44 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1366978377-16823-1-git-send-email-dingel@linux.vnet.ibm.com> <1366978377-16823-4-git-send-email-dingel@linux.vnet.ibm.com> <5AAF60BF-6909-45E4-8D61-B9B8B21CA95F@suse.de> <517AA059.4000400@de.ibm.com> <3D4AF3D5-CFA4-4352-8203-2739B17185A5@suse.de> In-Reply-To: <3D4AF3D5-CFA4-4352-8203-2739B17185A5@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/10] S390: Check Bootdevice Type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Christian Paro , qemu-devel@nongnu.org, Dominik Dingel On 26/04/13 17:48, Alexander Graf wrote: >> So I suggest to go with this patch and implement later on what we >> agree upon? > > I don't see how having "first device we find" is any better than a > rushed interface we need to agree on right before 1.5 hard freeze. Exactly, find first device isnt better ;-) See, the current code chooses the first subchannel that matches. This boils down to "a random disk" as soon as you have more than one. With this patch the user can at least specify the devno of the disk.It even works out of the box with libvirt. Let's just release 1.5 with the very simple one and then go for something awesome in the next version. Exactly - and having a list is more in the awesome area. Beiing able to specify the first disk and pass that in a register to the bios is of course not a full-features interface, but it works and can be changed. Just to double check: do you agree that we can change the interface between ipl device and bios at any time? Christian