From: Eric Sandeen <sandeen@redhat.com>
To: linux-btrfs <linux-btrfs@vger.kernel.org>
Cc: Liu Bo <liubo2009@cn.fujitsu.com>
Subject: Question on btrfs filesystem defragment args
Date: Fri, 26 Apr 2013 11:08:43 -0500 [thread overview]
Message-ID: <517AA68B.9060600@redhat.com> (raw)
Liu Bo created test 284 for xfstests to exercise btrfs defragmentation.
One test sends an argument including "-s -1" meaning "start at negative one"
That's failing today, because parse_size now rejects negative numbers.
(that might be something to fix on its own, since length = (u64)-1
might imply the whole file, per kernel comments).
But has "start at -1" ever had an expected meaning? That doesn't make
sense to me, but the test does it:
+echo "a single file | start < 0 && 0 < len < file size | off"
+_rundefrag 1 2 1
...
+_btrfs_online_defrag()
+{
+ str=""
+ if [ "$2" = "2" ];then
+ str="$str -s -1 -l $((filesize / 2)) "
and expects a silent result:
...
+a single file | default | on
+a single file | start < 0 && 0 < len < file size | off
+a single file | start > file size && 0 < len < file size | off
...
What was this test intended to do when it was written?
Thanks,
-Eric
reply other threads:[~2013-04-26 16:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517AA68B.9060600@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.