From: Eric Blake <eblake@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, phrdina@redhat.com, armbru@redhat.com,
qemu-devel@nongnu.org, lcapitulino@redhat.com,
stefanha@gmail.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/7] block: move snapshot code in block.c to block/snapshot.c
Date: Fri, 26 Apr 2013 13:05:48 -0600 [thread overview]
Message-ID: <517AD00C.7040906@redhat.com> (raw)
In-Reply-To: <1366968675-1451-4-git-send-email-xiawenc@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
On 04/26/2013 03:31 AM, Wenchao Xia wrote:
> All snapshot related code, except bdrv_snapshot_dump(), is moved to
> block/snapshot.c. bdrv_snapshot_dump() will be moved to another file later.
> It also fixes small code style errors reported by check script.
>
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
> block.c | 105 ------------------------------------------
> block/snapshot.c | 114 ++++++++++++++++++++++++++++++++++++++++++++++
> include/block/block.h | 28 ++---------
> include/block/snapshot.h | 27 +++++++++--
> 4 files changed, 142 insertions(+), 132 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-04-26 19:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 9:31 [Qemu-devel] [PATCH 0/7] qapi and snapshot code clean up in block layer Wenchao Xia
2013-04-26 9:31 ` [Qemu-devel] [PATCH 1/7] block: drop bs_snapshots global variable Wenchao Xia
2013-04-26 9:31 ` [Qemu-devel] [PATCH 2/7] block: move bdrv_snapshot_find() to block/snapshot.c Wenchao Xia
2013-04-26 9:31 ` [Qemu-devel] [PATCH 3/7] block: move snapshot code in block.c " Wenchao Xia
2013-04-26 19:05 ` Eric Blake [this message]
2013-04-26 9:31 ` [Qemu-devel] [PATCH 4/7] block: distinguish id and name in bdrv_find_snapshot() Wenchao Xia
2013-04-26 14:34 ` Stefan Hajnoczi
2013-04-26 14:47 ` Eric Blake
2013-04-27 3:34 ` Wenchao Xia
2013-04-30 17:52 ` Eric Blake
2013-04-30 18:16 ` Eric Blake
2013-05-02 2:02 ` Wenchao Xia
2013-05-02 21:12 ` Pavel Hrdina
2013-04-26 9:31 ` [Qemu-devel] [PATCH 5/7] block: move collect_snapshots() and collect_image_info() to block/qapi.c Wenchao Xia
2013-04-26 9:31 ` [Qemu-devel] [PATCH 6/7] block: move qmp and info dump related code " Wenchao Xia
2013-04-30 17:50 ` Eric Blake
2013-04-26 9:31 ` [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump() Wenchao Xia
2013-04-26 14:46 ` Stefan Hajnoczi
2013-04-27 3:37 ` Wenchao Xia
2013-04-29 19:05 ` Luiz Capitulino
2013-05-02 2:05 ` Wenchao Xia
2013-05-02 12:02 ` Luiz Capitulino
2013-05-03 2:51 ` Wenchao Xia
2013-05-06 2:09 ` Wenchao Xia
2013-05-06 13:22 ` Luiz Capitulino
2013-05-15 2:10 ` Wenchao Xia
2013-05-15 12:28 ` Luiz Capitulino
2013-05-16 2:22 ` Wenchao Xia
2013-05-16 12:17 ` Luiz Capitulino
2013-05-17 3:30 ` Wenchao Xia
2013-05-17 12:30 ` Luiz Capitulino
2013-05-20 2:39 ` Wenchao Xia
2013-05-22 2:09 ` Wenchao Xia
2013-05-22 12:23 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517AD00C.7040906@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.