From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVoTM-0004zt-B0 for qemu-devel@nongnu.org; Fri, 26 Apr 2013 15:38:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVoTJ-00058X-Ca for qemu-devel@nongnu.org; Fri, 26 Apr 2013 15:38:20 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:52409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVoTJ-00058F-2y for qemu-devel@nongnu.org; Fri, 26 Apr 2013 15:38:17 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Apr 2013 20:34:32 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id E47431B08061 for ; Fri, 26 Apr 2013 20:38:12 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3QJc23253018842 for ; Fri, 26 Apr 2013 19:38:02 GMT Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3QJcCOh002055 for ; Fri, 26 Apr 2013 13:38:12 -0600 Message-ID: <517AD7A3.1090707@de.ibm.com> Date: Fri, 26 Apr 2013 21:38:11 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1366978377-16823-1-git-send-email-dingel@linux.vnet.ibm.com> <1366978377-16823-2-git-send-email-dingel@linux.vnet.ibm.com> <8761z9i70k.fsf@codemonkey.ws> <20130426200118.0dedc20f@BR9TG4T3.de.ibm.com> In-Reply-To: <20130426200118.0dedc20f@BR9TG4T3.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/10] Common: Add a default bootindex for all applicable devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dominik Dingel Cc: qemu-devel@nongnu.org, Anthony Liguori , Alexander Graf On 26/04/13 20:01, Dominik Dingel wrote: > On Fri, 26 Apr 2013 11:36:11 -0500 > Anthony Liguori wrote: > >> Dominik Dingel writes: >> >>> Currently only devices with a positive boot index will be pushed in the >>> fw_boot_order queue, so if no boot index at all will be specified, >>> the queue ends up empty. >>> >>> Instead we push exactly as docs/bootindex.txt says the devices with >>> the lowest possible boot priority at the tail of the queue, >>> because we give them the highest available boot index. >>> >>> Signed-off-by: Dominik Dingel >> >> Wouldn't this break the ability to say: "don't every try to boot from >> this device?" >> >> As an example, some people want to force PXE boot to not be tried on >> certain networks. >> >> Regards, >> >> Anthony Liguori > > That is correct, hmm. The thing is, if we don't submit a bootindex, we will assign -1 in virtio-blk and virtio-net. This would forbid that the device would be booted from. > Where docs/bootindex.txt says: if a device got no bootindex, it gets the lowest possibly priority... Hmm, reading all this, I changed my mind :-) I think we should just leave out patch 1 for now. Anthony brought up a valid point, we want to be able to specify for a device "never boot from it". >>From an s390 point of view, it would even make sense to say "If the user does not provide a boot index, then the system wont boot. We leave the system in stopped state." Predictability is more important than clever guessing in this environment. Christian