From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVojc-0006Yq-UJ for qemu-devel@nongnu.org; Fri, 26 Apr 2013 15:55:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVojb-00024O-OD for qemu-devel@nongnu.org; Fri, 26 Apr 2013 15:55:08 -0400 Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:41706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVojb-00023s-G6 for qemu-devel@nongnu.org; Fri, 26 Apr 2013 15:55:07 -0400 Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Apr 2013 20:51:16 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id E3281219002D for ; Fri, 26 Apr 2013 20:57:30 +0100 (BST) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3QJsOIF53543076 for ; Fri, 26 Apr 2013 19:54:24 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3QJsXEa012224 for ; Fri, 26 Apr 2013 13:54:33 -0600 Message-ID: <517ADB78.3070800@de.ibm.com> Date: Fri, 26 Apr 2013 21:54:32 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1366978377-16823-1-git-send-email-dingel@linux.vnet.ibm.com> <1366978377-16823-10-git-send-email-dingel@linux.vnet.ibm.com> <496A9595-9B28-48C6-B08D-64361B3C20C2@suse.de> <20130426200812.1bbcc190@BR9TG4T3.de.ibm.com> <7D1D8BDA-CC1A-4692-B249-733D2687BA82@suse.de> In-Reply-To: <7D1D8BDA-CC1A-4692-B249-733D2687BA82@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/10] S390: Pass per-device loadparm values for CCW blk and net devs. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Christian Paro , qemu-devel@nongnu.org, Dominik Dingel On 26/04/13 20:14, Alexander Graf wrote: > > On 26.04.2013, at 20:08, Dominik Dingel wrote: > >> On Fri, 26 Apr 2013 18:52:48 +0200 >> Alexander Graf wrote: >> >>> >>> On 26.04.2013, at 14:12, Dominik Dingel wrote: >>> >>>> From: Christian Paro >>>> >>>> Provide a loadparm property which can be used to pass IPL load >>>> parameters on a per-device basis for VirtioCcwDevice instances >>>> representing block and network devices. >>>> >>>> Signed-off-by: Christian Paro >>>> >>>> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c >>>> index 56539d3..23d042f 100644 >>>> --- a/hw/s390x/virtio-ccw.c >>>> +++ b/hw/s390x/virtio-ccw.c >>>> @@ -791,6 +791,7 @@ static const VirtIOBindings virtio_ccw_bindings = { >>>> >>>> static Property virtio_ccw_net_properties[] = { >>>> DEFINE_PROP_STRING("devno", VirtioCcwDevice, bus_id), >>>> + DEFINE_PROP_UINT32("loadparm", VirtioCcwDevice, loadparm, 0), >>> >>> We don't support netboot yet, right? Also is "loadparm" an architected name? Wouldn't "bootmap_id" or something that actually tells the user what's going on fit better? >>> >>> >>> Alex >> >> Christian had the idea to name it subindex, but I don't know, to be honest, I like the general open solution more, especially for the commandline interface. What if we later on want to change the behaviour, loadparm, or better biosparameter is so general... where bootmap_id is narrowed down. You should probably specify the Christian.. ;-) My vote was for loadparm, because thats how the parameter is called in HMC and in z/VM as well as under /sys/firmware/reipl/ccw/loadparm etc. On the other hand its only loadparm for ccw disk devices. fcp has wwpn,lun etc. Its getting late in the cycle, so lets focus on the bootindex and defer this after 1.5.