Re: [PATCH 1/1] glib-2.0-native: do_compile failed on opensuse 12.2 64bit

[Robert Yang <liezhi.yang@windriver.com>]

On 04/26/2013 08:08 PM, Burton, Ross wrote:
> Hi,
>
> On 26 April 2013 12:41, Robert Yang <liezhi.yang@windriver.com> wrote:
>> The error message:
>>    File "/path/to/glib-2.34.3/gio/gdbus-2.0/codegen/parser.py", line 25, in <module>
>>      import xml.parsers.expat
>>
>> ImportError: No module named xml.parsers.expat
>> make[2]: *** [gdbus-daemon-generated.h] Error 1
>>
>> This is because opensuse 12.2 doesn't install the expat.py (one of
>> python's lib) by default, but our native python provides it, use the
>> native python would fix the problem.
>
> I don't like this.
>
> xml.parsers.expat is a standard Python library that's been integrated since 2.0:
>
> http://docs.python.org/2/library/pyexpat.html#module-xml.parsers.expat
>
> If we can't assume that a distribution has shipped a working Python
> we've got bigger problems.
>
> We could sanity check this in some way, maybe in the recipe's
> configure step so we can give a nicer message, but I don't think we
> should depend on pythonnative when we're talking about a standard
> feature of Python.
>

Hi Ross,

Thanks for the review, please see more comments:
The glib-2.0-native had already depend on python-native before this patch,
the depends chain is:

glib-2.0-native -> python-argparse-native -> python-native

I inherit the glib-2.0-native is for using the ${PYTHON} variable, it doesn't
change its depends, since we had built python-native already, and it works,
it seems more reasonable to use it rather than show error message and let the
user install other pkgs on the host, I think that this is what our native
recipe for.

// Robert


> Ross
>
>