From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Stornelli Subject: Re: [PATCH] vfs: no need to check about IS_IMMUTABLE in do_fallocate Date: Sat, 27 Apr 2013 08:56:19 +0200 Message-ID: <517B7693.4080300@gmail.com> References: <1367037739-2017-1-git-send-email-ashish.sangwan2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, Ashish Sangwan , Namjae Jeon To: Ashish Sangwan Return-path: Received: from mail-ea0-f171.google.com ([209.85.215.171]:63103 "EHLO mail-ea0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070Ab3D0HDb (ORCPT ); Sat, 27 Apr 2013 03:03:31 -0400 Received: by mail-ea0-f171.google.com with SMTP id b10so1023036eae.30 for ; Sat, 27 Apr 2013 00:03:30 -0700 (PDT) In-Reply-To: <1367037739-2017-1-git-send-email-ashish.sangwan2@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Il 27/04/2013 06:42, Ashish Sangwan ha scritto: > From: Ashish Sangwan > > In do_fallocate, first there is check for FMODE_WRITE and after that > there is second check for IS_IMMUTABLE. > A file cannot be opened in write mode if the corresponding inode is > immutable, hence the second check is not required. > > Signed-off-by: Ashish Sangwan > Signed-off-by: Namjae Jeon See commit 1ca551c6caae7b52178555cdedea6ca26444be46. Regards, Marco