All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <elder@inktank.com>
To: ceph-devel@vger.kernel.org
Subject: [PATCH 4/5] rbd: don't bother checking whether order changes
Date: Sat, 27 Apr 2013 14:39:55 -0500	[thread overview]
Message-ID: <517C298B.6050801@inktank.com> (raw)
In-Reply-To: <517C2914.8030400@inktank.com>

When a format 2 image is refreshed, code is in place to verify that
the object order never changes from what it was originally.  This
relies on the fact that the refresh will occur *after* an initial
load of information about the image.

An upcoming patch makes it possible for the refresh to occur first,
so we can no longer make this order check.  The order really can't
ever change anyway--this was just a sanity check.  So get rid of it.

Signed-off-by: Alex Elder <elder@inktank.com>
---
 drivers/block/rbd.c |    8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index d7a36d1..1832b6a 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -4015,20 +4015,12 @@ static char *rbd_dev_snap_info(struct rbd_device
*rbd_dev, u32 which,
 static int rbd_dev_v2_refresh(struct rbd_device *rbd_dev, u64 *hver)
 {
 	int ret;
-	__u8 obj_order;

 	down_write(&rbd_dev->header_rwsem);

-	/* Grab old order first, to see if it changes */
-
-	obj_order = rbd_dev->header.obj_order,
 	ret = rbd_dev_v2_image_size(rbd_dev);
 	if (ret)
 		goto out;
-	if (rbd_dev->header.obj_order != obj_order) {
-		ret = -EIO;
-		goto out;
-	}
 	rbd_update_mapping_size(rbd_dev);

 	ret = rbd_dev_v2_snap_context(rbd_dev, hver);
-- 
1.7.9.5


  parent reply	other threads:[~2013-04-27 19:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-27 19:37 [PATCH 0/5] rbd: avoid snapshot update race Alex Elder
2013-04-27 19:39 ` [PATCH 1/5] rbd: move more initialization into rbd_dev_probe_image() Alex Elder
2013-04-27 19:39 ` [PATCH 2/5] rbd: define rbd_header_name() Alex Elder
2013-04-27 19:39 ` [PATCH 3/5] rbd: don't clean up watch in device release function Alex Elder
2013-04-27 19:39 ` Alex Elder [this message]
2013-04-27 19:40 ` [PATCH 5/5] rbd: set up watch in rbd_dev_probe_image() Alex Elder
2013-04-27 19:42 ` [PATCH 0/5] rbd: avoid snapshot update race Alex Elder
2013-04-29 17:52   ` Alex Elder
2013-04-30 19:13     ` Josh Durgin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517C298B.6050801@inktank.com \
    --to=elder@inktank.com \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.