From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWCMY-0002ML-Iy for qemu-devel@nongnu.org; Sat, 27 Apr 2013 17:08:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWCMX-0002Of-KL for qemu-devel@nongnu.org; Sat, 27 Apr 2013 17:08:54 -0400 Received: from mail-ee0-f43.google.com ([74.125.83.43]:44370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWCMX-0002OR-Cq for qemu-devel@nongnu.org; Sat, 27 Apr 2013 17:08:53 -0400 Received: by mail-ee0-f43.google.com with SMTP id b47so1248714eek.2 for ; Sat, 27 Apr 2013 14:08:52 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <517C3E56.6010705@redhat.com> Date: Sat, 27 Apr 2013 23:08:38 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1367063321-19196-1-git-send-email-pbonzini@redhat.com> <1367063321-19196-5-git-send-email-pbonzini@redhat.com> <517BCF1C.2090508@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/5] add missing inclusions of config-host.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: blauwirbel@gmail.com, sw@weilnetz.de, qemu-devel@nongnu.org Il 27/04/2013 15:19, Peter Maydell ha scritto: >>>> >> > The next patch will add a dependency of qemu/osdep.h on config-host.h. >>>> >> > It could be nicer to use qemu-common.h, but I prefer to be safer this >>>> >> > close to hard feature freeze. >>> >> Can't we just include config-host.h from osdep.h ? >> > >> > Yes, but that is also a bit more risky than I think we can afford at >> > this point. > Not sure I understand where the risk is -- all it does is > define a pile of CONFIG_* macros, right? Yeah, I was unsure about triggering changes in all files that include osdep.h, but there aren't that many actually. Most files get it via qemu-common.h, and qemu-common.h includes config-host.h. Paolo